Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing performance issues programme #43

Closed
6 of 7 tasks
oparoz opened this issue Feb 28, 2015 · 7 comments
Closed
6 of 7 tasks

Fixing performance issues programme #43

oparoz opened this issue Feb 28, 2015 · 7 comments

Comments

@oparoz
Copy link
Contributor

oparoz commented Feb 28, 2015

This is a meta ticket which tracks all the various work being done to improve the performance of the app

Please support and comment on individual tickets if you want to help as it's difficult to track what's important to backers otherwise.

Loading the app

Getting thumbnails

For issues in core, see this meta ticket: owncloud/core#13609
Things should be much better on oC 8.1+, once core can generate thumbnails in seconds rather than minutes for large media files.

Feel free to add your thoughts and to raise new issues to address specific problems.

There is a $60 open bounty on this issue. Add to the bounty at Bountysource.

@oparoz oparoz changed the title Fixing performance issues programme Fixing performance issues programme [$15] Mar 5, 2015
@oparoz oparoz added the bounty label Mar 5, 2015
@oparoz oparoz changed the title Fixing performance issues programme [$15] Fixing performance issues programme [$30] Mar 5, 2015
@oparoz oparoz self-assigned this Mar 8, 2015
@cbxk1xg
Copy link

cbxk1xg commented Mar 12, 2015

I would be pleased to help you guys with the code. As I wrote earlier, I developed similar stuff before. And I guess it's more an user experience thing than a performance issue. But I do also have some ideas to improve the performance.

@oparoz
Copy link
Contributor Author

oparoz commented Mar 12, 2015

That's great news! :)
From my point of view, what's most needed is fixes in core regarding thumbnail generation:

  • Having preview categories and returning a predefined thumbnail. Asked size is 1920x1080, which is larger than 1024x1024, but smaller than 2048x2048. Return 1024 or 2048 and let the browser shrink it, etc.
  • Async thumbnail generation, triggered at upload time Migrate preview generation to async job execution core#11685 (comment) , but we're told to wait for a solution. Also, bear in mind that in 8.1, we should have the max preview which is used to create all the smaller sizes.

In the app itself, we could have this:

  • Generate thumbnails on demand, so that users don't have to wait too long before being able to see something Generate thumbnails on demand #22 . This cannot be done offline because of encryption.

But I also would like to hear what you thought of :)
Make sure you check with me before touching files as some classes may already be in a different state internally, so that we can work together.

@oparoz oparoz changed the title Fixing performance issues programme [$30] Fixing performance issues programme [$60] Mar 27, 2015
@libasys
Copy link

libasys commented Mar 31, 2015

A new idea to fix performance issue, i have changed the gallery searching mechanism. In OC core you have a function called searchRaw. With this function you can search explicite for a file. My idea, I place or rename an image to "cover.jpg" in a folder. Now with the search function above, we only search for folders with "cover.jpg". With this mechanism you have a simple structure and a big performance improvement. The 2. part, i use the cover.jpg as thumbnail for the folder and as info, so if you add iptc information to this file like title, than the folder gets the title of the cover.jpg! So you need no startpath and no scanning for all files. You have the control what is shown up in the gallery! No need to walk from folder to subfolder and soon!

@oparoz
Copy link
Contributor Author

oparoz commented Mar 31, 2015

Could I ask you to open a separate issue for this so that people can voice their opinion?

@oparoz
Copy link
Contributor Author

oparoz commented Sep 27, 2015

occ command to generate thumbnails: #387

@oparoz oparoz added this to the 9.0-current milestone Dec 18, 2015
@oparoz oparoz modified the milestones: 9.1-next, 9.0-current Feb 11, 2016
@oparoz
Copy link
Contributor Author

oparoz commented Feb 13, 2016

There is now a PR to show thumbnails before the row is completed: #511

@oparoz oparoz modified the milestones: 9.2-next, 9.1-current Jun 13, 2016
@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#18

@oparoz oparoz closed this as completed Sep 4, 2016
@oparoz oparoz removed the bounty label Apr 20, 2017
@oparoz oparoz changed the title Fixing performance issues programme [$60] Fixing performance issues programme Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants