-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate the available width for the breadcrumb based on shown buttons #443
Comments
@oparoz I want to fix this issue. Can you please tell a little more about what needs to be done in this? |
I've updated the OP with more details. That gives you a bit of investigating work to do to familiarise yourself with the GUI components. Regarding tasks, do you want to stay with Javascript or do you want to start working on some PHP jobs? In general, any task with a label "Coder wanted" can be picked and I can clarify some of them or tell you if it's not the right time to look at it, etc. |
@oparoz I will have a look at the updated description. |
Here is a selection: #4 #193 (comment) #213 #565 If none of them float your boat, let me know and I'll try to find bigger tasks. |
I've added another one: #566 |
@oparoz Cool! I will have a look at all of them along with this one and get back to you. 👍 |
OK and remember to sign the contributor agreement if you intend on delivering larger PRs. That way you can also manage labels and assign yourself to tasks. |
@oparoz Yeah Sure. Where can I find the contributor agreement? |
Yeah! Thanks! Got it! 👍 |
I've also added some basic app ideas to the wiki |
@oparoz I am having a look at those basic app ideas that you have added. I will start developing one of those to have grip on the AppFramework. Thanks! |
@oparoz Secondly, Where can I communicate with you regarding GSoC projects? Is IRC fine? |
I'm rarely on IRC, unless I'm working on something as it's too distracting and unreliable. Emails works best, unless code needs to be discussed live, in which case we can meet on IRC. |
This issue was moved to nextcloud/gallery#98 |
The app is currently using the worst case scenario, the one where all buttons are shown, which means that there will be a large gap on public galleries per example if the only button shown is the switch to Files button.
The plan is to add 50px per button at view init time.
In more details
We define
Gallery.buttonsWidth
at 350 pixels. that's the worst case scenario.When the view is resized, we do this:
Gallery.view.breadcrumb.setMaxWidth($(window).width() - Gallery.buttonsWidth);
The 350 pixels area may not necessarily be filled with buttons, leaving some empty space.
Plan
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: