Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate the available width for the breadcrumb based on shown buttons #443

Closed
4 tasks
oparoz opened this issue Oct 18, 2015 · 15 comments
Closed
4 tasks

Comments

@oparoz
Copy link
Contributor

oparoz commented Oct 18, 2015

The app is currently using the worst case scenario, the one where all buttons are shown, which means that there will be a large gap on public galleries per example if the only button shown is the switch to Files button.

The plan is to add 50px per button at view init time.

In more details

We define Gallery.buttonsWidth at 350 pixels. that's the worst case scenario.

When the view is resized, we do this:
Gallery.view.breadcrumb.setMaxWidth($(window).width() - Gallery.buttonsWidth);

The 350 pixels area may not necessarily be filled with buttons, leaving some empty space.

Plan

  • List all buttons which can be shown on the controls bar
  • List the minimum number of buttons which can be show on the interface
  • Define the number of pixels a button takes
  • Write a function which updates Gallery.buttonsWidth based on the number of buttons currently shown

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@oparoz oparoz added this to the 8.2.1-next-maintenance milestone Oct 18, 2015
@oparoz oparoz modified the milestones: 9.0-current, 8.2.1-current-maintenance Nov 3, 2015
@oparoz oparoz modified the milestones: 9.1-next, 9.0-current Feb 11, 2016
@imjalpreet
Copy link
Member

@oparoz I want to fix this issue. Can you please tell a little more about what needs to be done in this?
Secondly, can you also assign me some more tasks, so that I can get used to the code?
Thanks!

@oparoz
Copy link
Contributor Author

oparoz commented Mar 8, 2016

I've updated the OP with more details. That gives you a bit of investigating work to do to familiarise yourself with the GUI components.

Regarding tasks, do you want to stay with Javascript or do you want to start working on some PHP jobs? In general, any task with a label "Coder wanted" can be picked and I can clarify some of them or tell you if it's not the right time to look at it, etc.

@imjalpreet
Copy link
Member

@oparoz I will have a look at the updated description.
Secondly, I am fine with both PHP and JS Jobs. Can you suggest me some jobs that can be looked at now? Thanks!

@oparoz
Copy link
Contributor Author

oparoz commented Mar 8, 2016

Here is a selection: #4 #193 (comment) #213 #565
There is also a PR which could be finished, but you'll have to ask the person currently assigned: #512

If none of them float your boat, let me know and I'll try to find bigger tasks.

@oparoz
Copy link
Contributor Author

oparoz commented Mar 8, 2016

I've added another one: #566

@imjalpreet
Copy link
Member

@oparoz Cool! I will have a look at all of them along with this one and get back to you. 👍

@oparoz
Copy link
Contributor Author

oparoz commented Mar 8, 2016

OK and remember to sign the contributor agreement if you intend on delivering larger PRs. That way you can also manage labels and assign yourself to tasks.

@imjalpreet
Copy link
Member

@oparoz Yeah Sure. Where can I find the contributor agreement?

@oparoz
Copy link
Contributor Author

oparoz commented Mar 8, 2016

@imjalpreet
Copy link
Member

Yeah! Thanks! Got it! 👍

@oparoz
Copy link
Contributor Author

oparoz commented Mar 10, 2016

I've also added some basic app ideas to the wiki

@imjalpreet
Copy link
Member

@oparoz I am having a look at those basic app ideas that you have added. I will start developing one of those to have grip on the AppFramework. Thanks!

@imjalpreet
Copy link
Member

@oparoz Secondly, Where can I communicate with you regarding GSoC projects? Is IRC fine?

@oparoz
Copy link
Contributor Author

oparoz commented Mar 10, 2016

I'm rarely on IRC, unless I'm working on something as it's too distracting and unreliable. Emails works best, unless code needs to be discussed live, in which case we can meet on IRC.

@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#98

@oparoz oparoz closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants