-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailsview to the photowall #559
Comments
@Bugsbane @jancborchardt @blizzz @setnes @deMattin - What do you think? |
I would prefer it, like it is in files sidebar.
|
Yeah, I agree with @deMattin here. Even if we absolutely need to design our own detail view, we should model it as closely as possible to the one in Files. Otherwise people need to learn 2 different things for such elementary tasks, which is not acceptable. |
And thinking about the mobile experience, users would end up with half a vertical sidebar which would offer a pretty bad ux. I guess we'll have to fog out all the other pictures to make it clear which one is currently selected |
I have no idea, how to get this on mobile except in portrait mode of smartphone with only a single picture on the top (should be possible to switch to next one) and the informations at the bottom on the other half of screen. |
We'll have to have a different layout based on orientation. |
I propose the following:
This will work well on mobile as well as normal displays, since the idea of creating a half vertical sidebar will give no use. |
I don't think it will work, because there is already a slight problem with labels on hover when you're scrolling. As labels are quite discreet, it doesn't matter much, but it would be bad if there were popups coming up when scrolling The simple solution will be to show the star and the 3 dots menu as an overlay, probably top right, so that there is enough space for the filename at the bottom. Then the details view would show up like on the slideshow (#549). On mobile, it would fill all the space in portrait mode and half the space in landscape mode, like in Files. |
What I was saying about the "half a vertical sidebar" is that with the drop down, the top of the screen in portrait mode would have a couple of images and the bottom something like half of the sharing dialogue and that's not very useful. |
I would really advise that we don’t waste time on thinking about our own implementation here. It’s important that we standardize across apps, and that means we need to find a way (work together with core devs such as @PVince81) to get the sidebar standardized and usable across apps. |
Sure, but the issue in core is in the backlog and requires changing a lot of core internals, so we're probably a year away (10.0) from a solution (idea->politics->architecture->resources->implementation). |
This issue was moved to nextcloud/gallery#124 |
Feature request
User type: All
User level: All
Description
We can't re-use the sidebar designed for Files as it only works in Files, especially since plugins used in tabs target the Files app (#548), so we'll have to design our own.
We can probably re-use the tabs logic to be able to easily show additional information, but we don't even need to use a sidebar.
I find this design interesting
Basic info
Additional info
Benefit / value
Risk / caveats
Sponsorship
None
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: