Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] [oCIS] Respect Capability "privateLinks": false #1138

Open
9 tasks
michaelstingl opened this issue Aug 22, 2022 · 0 comments
Open
9 tasks

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented Aug 22, 2022

Is your feature request related to a problem? Please describe.

oCIS doesn't have the oC10-style private links. It's also announced as false in the capabilities:

% cat ocis.capabilities | jq .ocs.data.capabilities.files
{
  "privateLinks": false,
  "bigfilechunking": false,
  "undelete": true,
  "versioning": true,
  "favorites": false,
  "blacklisted_files": [],
  "tus_support": {
    "version": "1.0.0",
    "resumable": "1.0.0",
    "extension": "creation,creation-with-upload",
    "max_chunk_size": 100000000,
    "http_method_override": ""
  },
  "archivers": [
    {
      "enabled": true,
      "version": "2.0.0",
      "formats": [
        "tar",
        "zip"
      ],
      "archiver_url": "/archiver",
      "max_num_files": "10000",
      "max_size": "1073741824"
    }
  ],
  "app_providers": [
    {
      "enabled": true,
      "version": "1.0.0",
      "apps_url": "/app/list",
      "open_url": "/app/open",
      "new_url": "/app/new"
    }
  ]
}

Describe the solution you'd like

iOS app should respect the capability, and hide the private link entries on all screens.

Additional context

Desktop issues:

Android issue:

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants