Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

fix email length in the database #1518

Merged
merged 1 commit into from
Jun 8, 2016
Merged

fix email length in the database #1518

merged 1 commit into from
Jun 8, 2016

Conversation

tahaalibra
Copy link
Contributor

@tahaalibra tahaalibra commented Jun 4, 2016

change email length from 64 to 255 in the database
@ChristophWurst @Gomez

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @ChristophWurst and @drfuture to be potential reviewers

@ChristophWurst
Copy link
Contributor

@tahaalibra please set the labels appropriately when submitting pull requests, thanks :)

@ChristophWurst
Copy link
Contributor

please add a changelog entry for this fix

@tahaalibra tahaalibra force-pushed the fix-email-length branch 3 times, most recently from 68e160f to 50428f1 Compare June 4, 2016 09:59
@ChristophWurst
Copy link
Contributor

@viki53 you volunteered for testing, can you test with innodb please?

@ChristophWurst
Copy link
Contributor

needs rebase

@tahaalibra
Copy link
Contributor Author

@ChristophWurst done!!

@ChristophWurst
Copy link
Contributor

👍 thanks

@ChristophWurst ChristophWurst merged commit b129164 into master Jun 8, 2016
@ChristophWurst ChristophWurst deleted the fix-email-length branch June 8, 2016 07:56
@viki53
Copy link

viki53 commented Jun 8, 2016

@ChristophWurst Sure! Which branch/commit should I clone to test?

@ChristophWurst
Copy link
Contributor

this one ;-)

@viki53
Copy link

viki53 commented Jun 9, 2016

I just tried to install the app.

DB upgrade went fine but then I got an OwnCloud error when I accessed the Web interface.

Now that I fixed that by upgrading other apps (which made OwnCloud deactivate all the apps), I can't enable the Mail app because it "makes the server unstable" apparently…

@ChristophWurst
Copy link
Contributor

ChristophWurst commented Jun 9, 2016

makes the server unstable

could be a duplicate https://github.com/owncloud/mail/issues/1522.
Could you provide the info asked by the issue_template so we can try to reproduce and fix that bug? Thx

@viki53
Copy link

viki53 commented Jun 9, 2016

I posted a comment on the #1522 issue with all the details I can get. Let me know if it helps

@viki53
Copy link

viki53 commented Jun 9, 2016

All good! 👍

Upgrade worked fine, app seems to work as expected (at least for the retrieving mails part).

Thanks for the fix!


BTW, will the app update as usual even though I installed via a manual download? Or will I need to replace it with a version from the store?

@ChristophWurst
Copy link
Contributor

@viki53 the version in the store is signed and you should get the next updated when it's available. I don't think you need to replace it now. It should be fine :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants