Market app should not be able to downgrade itself

[davitol]

Description

Having a local market version newer that the one published in marketplace, we should not downgrade the app.

Steps to reproduce

1 . Having an oC 10.0.10 server, install market app v0.3.0 using a tarball
2. Upgrade oC server to daily master

Expected result

After the upgrade the market app should be equal to the content of market 0.3.0 tarball

Current behavior

Market app shows 0.2.5 version and the content of market folder is mixed.
diff -r market-0.3.0RC1/ market-afterupdate Files after the update are from 0.3.0RC1 except info.xml and vendor/autoload.php and appinfo/signature.json

@PVince81 @DeepDiver1975 @IljaN jfyi

Other info

App list before upgrade

Enabled:
  - comments: 0.3.0
  - configreport: 0.1.1
  - dav: 0.3.2
  - federatedfilesharing: 0.3.1
  - federation: 0.1.0
  - files: 1.5.1
  - files_external: 0.7.1
  - files_sharing: 0.10.1
  - files_trashbin: 0.9.1
  - files_versions: 1.3.0
  - files_videoplayer: 0.9.8
  - firstrunwizard: 1.1
  - market: 0.3.0
  - notifications: 0.3.4
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - updatenotification: 0.2.1
Disabled:
  - encryption
  - external
  - password_policy
  - user_external

Upgrade logs

root@05078a63dd1d: /var/www/owncloud # occ upgrade --major
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
2018-11-27T13:10:32+00:00 Set log level to debug
2018-11-27T13:10:32+00:00 Repair step: Upgrade app code from the marketplace
2018-11-27T13:10:33+00:00 Repair info: Using market to update existing apps
2018-11-27T13:10:33+00:00 Repair info: Attempting to update the following existing compatible apps from market:
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: comments
2018-11-27T13:10:33+00:00 Repair info: App (comments) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: configreport
2018-11-27T13:10:33+00:00 Repair info: App (configreport) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: dav
2018-11-27T13:10:33+00:00 Repair info: App (dav) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: federatedfilesharing
2018-11-27T13:10:33+00:00 Repair info: App (federatedfilesharing) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: federation
2018-11-27T13:10:33+00:00 Repair info: App (federation) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: files
2018-11-27T13:10:33+00:00 Repair info: App (files) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: files_external
2018-11-27T13:10:33+00:00 Repair info: App (files_external) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: files_sharing
2018-11-27T13:10:33+00:00 Repair info: App (files_sharing) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: files_trashbin
2018-11-27T13:10:33+00:00 Repair info: App (files_trashbin) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: files_versions
2018-11-27T13:10:33+00:00 Repair info: App (files_versions) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: firstrunwizard
2018-11-27T13:10:33+00:00 Repair info: App (firstrunwizard) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: market
2018-11-27T13:10:33+00:00 Repair info: App (market) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: notifications
2018-11-27T13:10:33+00:00 Repair info: App (notifications) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: provisioning_api
2018-11-27T13:10:33+00:00 Repair info: App (provisioning_api) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: systemtags
2018-11-27T13:10:33+00:00 Repair info: App (systemtags) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: Fetching app from market: updatenotification
2018-11-27T13:10:33+00:00 Repair info: App (updatenotification) is not known at the marketplace.
2018-11-27T13:10:33+00:00 Repair info: App was not updated: comments
2018-11-27T13:10:33+00:00 Repair info: App was not updated: configreport
2018-11-27T13:10:33+00:00 Repair info: App was not updated: dav
2018-11-27T13:10:33+00:00 Repair info: App was not updated: federatedfilesharing
2018-11-27T13:10:33+00:00 Repair info: App was not updated: federation
2018-11-27T13:10:33+00:00 Repair info: App was not updated: files
2018-11-27T13:10:33+00:00 Repair info: App was not updated: files_external
2018-11-27T13:10:33+00:00 Repair info: App was not updated: files_sharing
2018-11-27T13:10:33+00:00 Repair info: App was not updated: files_trashbin
2018-11-27T13:10:33+00:00 Repair info: App was not updated: files_versions
2018-11-27T13:10:33+00:00 Repair info: App was not updated: firstrunwizard
2018-11-27T13:10:33+00:00 Repair info: App was not updated: market
2018-11-27T13:10:33+00:00 Repair info: App was not updated: notifications
2018-11-27T13:10:33+00:00 Repair info: App was not updated: provisioning_api
2018-11-27T13:10:33+00:00 Repair info: App was not updated: systemtags
2018-11-27T13:10:33+00:00 Repair info: App was not updated: updatenotification
2018-11-27T13:10:34+00:00 Repair step: Repair MySQL database engine
2018-11-27T13:10:34+00:00 Repair step: Repair MySQL collation
2018-11-27T13:10:34+00:00 Repair info: Change collation for oc_migrations ...
2018-11-27T13:10:34+00:00 Repair step: Repair SQLite autoincrement
2018-11-27T13:10:34+00:00 Repair step: Repair orphaned reshare
2018-11-27T13:10:34+00:00 Repair step: Repair duplicate entries in oc_lucene_status
2018-11-27T13:10:34+00:00 Repair info: lucene_status table does not exist -> nothing to do
2018-11-27T13:10:34+00:00 Updating database schema
2018-11-27T13:10:35+00:00 Updated database
2018-11-27T13:10:35+00:00 Updating <market> ...
2018-11-27T13:10:35+00:00 Updated <market> to 0.2.5
2018-11-27T13:10:35+00:00 Updating <dav> ...
2018-11-27T13:10:36+00:00 Repair step: Remove invalid calendar and addressbook shares
2018-11-27T13:10:36+00:00 Updated <dav> to 0.4.0
2018-11-27T13:10:36+00:00 Updating <files_sharing> ...
2018-11-27T13:10:36+00:00 Updated <files_sharing> to 0.11.0
2018-11-27T13:10:36+00:00 Updating <notifications> ...
2018-11-27T13:10:37+00:00 Updated <notifications> to 0.4.1
2018-11-27T13:10:37+00:00 Repair step: Repair mime types
2018-11-27T13:10:37+00:00 Repair step: Detect file cache entries with path that does not match parent-child relationships
2018-11-27T13:10:37+00:00 Repair step: Generate ETags for file where no ETag is present.
2018-11-27T13:10:37+00:00 Repair info: ETags have been fixed for 0 files/folders.
2018-11-27T13:10:37+00:00 Repair step: Clean tags and favorites
2018-11-27T13:10:37+00:00 Repair info: 0 tags of deleted users have been removed.
2018-11-27T13:10:37+00:00 Repair info: 0 tags for delete files have been removed.
2018-11-27T13:10:37+00:00 Repair info: 0 tag entries for deleted tags have been removed.
2018-11-27T13:10:37+00:00 Repair info: 0 tags with no entries have been removed.
2018-11-27T13:10:37+00:00 Repair step: Drop old database tables
2018-11-27T13:10:37+00:00 Drop old database tables
2018-11-27T13:10:37+00:00
                                                    2018-11-27T13:10:37+00:00  Done
 28/28 [============================] 100%2018-11-27T13:10:37+00:00
2018-11-27T13:10:37+00:00 Repair step: Drop old background jobs
2018-11-27T13:10:37+00:00 Repair step: Remove getetag entries in properties table
2018-11-27T13:10:37+00:00 Repair info: Removed 0 unneeded "{DAV:}getetag" entries from properties table.
2018-11-27T13:10:37+00:00 Repair step: Repair outdated OCS IDs
2018-11-27T13:10:37+00:00 Repair step: Repair invalid shares
2018-11-27T13:10:37+00:00 Repair step: Remove old share propagation app entries
2018-11-27T13:10:37+00:00 Repair step: Move user avatars outside the homes to the new location
2018-11-27T13:10:37+00:00 Repair step: Remove shares of a users root folder
2018-11-27T13:10:37+00:00 Repair step: Repair unmerged shares
2018-11-27T13:10:37+00:00 Repair step: Disable extra themes
2018-11-27T13:10:37+00:00 Repair step: Repair sub shares
2018-11-27T13:10:37+00:00 Starting code integrity check...
2018-11-27T13:13:12+00:00 Finished code integrity check
2018-11-27T13:13:12+00:00 Update successful
2018-11-27T13:13:12+00:00 Maintenance mode is kept active
2018-11-27T13:13:12+00:00 Reset log level

info.xml after upgrade

 cat info.xml
<?xml version="1.0"?>
<info>
<id>market</id>
<name>Market</name>
<summary>Integrate the ownCloud marketplace into your ownCloud</summary>
<description>Easily manage ownCloud apps from within your ownCloud web interface. It connects your ownCloud with your marketplace account and lets you browse, install and update any apps from inside your ownCloud instance.

Please note: Since ownCloud X (10.0) every instance gets shipped with this app included. You do not need to install it separately.
To use this application click on "Files" in the top left corner and click on "Market" (cart icon) (Administrator privileges required) </description>
<licence>AGPL</licence>
<author>Thomas Müller, Felix Heidecke, Thomas Börger, Philipp Schaffrath</author>
<version>0.2.5</version>
<default_enable/>
<category>tools</category>
<screenshot>https://raw.githubusercontent.com/owncloud/screenshots/master/market/ownCloud-market-app.jpg</screenshot>
<dependencies>
<owncloud min-version="10.0" max-version="11.0.0.0" />
</dependencies>
<background-jobs>
<job>OCA\Market\CheckUpdateBackgroundJob</job>
</background-jobs>
<commands>
<command>OCA\Market\Command\InstallApp</command>
<command>OCA\Market\Command\UnInstallApp</command>
<command>OCA\Market\Command\ListApps</command>
<command>OCA\Market\Command\UpgradeApp</command>
</commands>
<navigation role="admin">
<route>market.page.index</route>
<order>100</order>
</navigation>
</info>