Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues when the market API key is an empty string #870

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

JammingBen
Copy link
Contributor

Due to owncloud/core#39554, null will be transformed to an empty string when retrieving values from the oc_appconfig table. This makes the market app unusable in this scenario, so we need to omit the API key if empty.

Related to owncloud/core#39616

@JammingBen JammingBen added the bug label Dec 27, 2021
@JammingBen JammingBen self-assigned this Dec 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 1cfc85c into master Dec 27, 2021
@JammingBen JammingBen mentioned this pull request Dec 27, 2021
44 tasks
@phil-davis phil-davis deleted the api-key-null branch December 27, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants