Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable10] Add common footer to notifications #207

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jun 15, 2018

Backport of #206
Closes #205

plain

html

@VicDeo VicDeo added this to the development milestone Jun 15, 2018
@VicDeo VicDeo self-assigned this Jun 15, 2018
@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #207 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10     #207   +/-   ##
===========================================
  Coverage       89.55%   89.55%           
  Complexity        133      133           
===========================================
  Files              18       18           
  Lines             536      536           
===========================================
  Hits              480      480           
  Misses             56       56
Flag Coverage Δ Complexity Δ
#phpunit 89.55% <ø> (ø) 133 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cee36d...365a73b. Read the comment docs.

@PVince81
Copy link
Contributor

merging this despite code freeze: reasons:

  • simple change with minimal additional QA overhead
  • to not bother theme admins again in a future release to go back adjusting theme templates again

@PVince81 PVince81 merged commit 8aef9f7 into stable10 Jun 21, 2018
@PVince81 PVince81 deleted the stable10-implement-205 branch June 21, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants