You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Whenever a notification is sent by API with one or multiple actions, the notification needs to be processed by a INotifier instance. If not INotifier instance exists or if it doesn't return a parsed action, the web UI will not display any actions.
The decision whether to send out an email for notifications is based whether said notification contains at least an action. Currently it is checking if there is an "action" and not a "parsedAction".
We should probably make this consistent to avoid confusing behavior.
I think this is a difficult decision. The reason to split the NotificationMailer in 2 classes was to simplify the dependencies instead of having one class depending on 7 others.
At the point where we check the notification we can't rely on parsedActions. We have to prepare the notification before checking. This would imply to move the NotificationManager and OptionsStorage up to the adapter, and the actual mailer will be left with very little things to do. We might want to merge both classes into one.
Whenever a notification is sent by API with one or multiple actions, the notification needs to be processed by a
INotifier
instance. If notINotifier
instance exists or if it doesn't return a parsed action, the web UI will not display any actions.The decision whether to send out an email for notifications is based whether said notification contains at least an action. Currently it is checking if there is an "action" and not a "parsedAction".
We should probably make this consistent to avoid confusing behavior.
@jvillafanez
The text was updated successfully, but these errors were encountered: