Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Backport of Clear user notifications from table after they… #223

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

sharidas
Copy link
Contributor

… are deleted

Clear user notifications from table after they are deleted.

Signed-off-by: Sujith H sharidasan@owncloud.com

@sharidas sharidas self-assigned this Aug 20, 2018
@sharidas sharidas added this to the development milestone Aug 20, 2018
@sharidas
Copy link
Contributor Author

Original PR #221

… are deleted

Clear user notifications from table after they are deleted.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas force-pushed the clear-notifications-after-user-deleted-stable10 branch from 9fd6054 to 2dd4cc4 Compare August 20, 2018 10:59
@codecov-io
Copy link

codecov-io commented Aug 20, 2018

Codecov Report

Merging #223 into stable10 will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10     #223      +/-   ##
==============================================
+ Coverage       89.55%   89.78%   +0.22%     
- Complexity        133      136       +3     
==============================================
  Files              18       18              
  Lines             536      548      +12     
==============================================
+ Hits              480      492      +12     
  Misses             56       56
Flag Coverage Δ Complexity Δ
#phpunit 89.78% <100%> (+0.22%) 136 <3> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/Handler.php 99.3% <100%> (+0.02%) 32 <1> (+1) ⬆️
appinfo/app.php 100% <100%> (ø) 0 <0> (ø) ⬇️
lib/AppInfo/Application.php 91.42% <100%> (+1.77%) 8 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b30014...2dd4cc4. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 7ab3dd8 into stable10 Aug 21, 2018
@PVince81 PVince81 deleted the clear-notifications-after-user-deleted-stable10 branch August 21, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants