Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications icon shows by default in top bar #65

Closed
jancborchardt opened this issue Feb 17, 2016 · 4 comments
Closed

Notifications icon shows by default in top bar #65

jancborchardt opened this issue Feb 17, 2016 · 4 comments
Labels
Milestone

Comments

@jancborchardt
Copy link
Member

Since some time, the notifications icon shows by default in the top bar. Even though there are no notifications.

When there are no notifications, there is no need for the icon to show. @nickvergessen

@jancborchardt jancborchardt added this to the 9.0-current milestone Feb 17, 2016
@nickvergessen
Copy link
Contributor

This is because we now have something that could show up: federated shares.
I think it's good to show the icon when something could show up, so the users get trained and know that it exists. It also helps app developers to get to know it and maybe add the functionality into their app...
Otherwise it never shows up when you don't receive a federated share, so how should they know?

@jancborchardt
Copy link
Member Author

Otherwise it never shows up when you don't receive a federated share, so how should they know?

When you do not receive a federated share, then it’s totally fine if it never shows up. If we want to advertise stuff to developers then we should do that, and not push it out to every single user. Especially not where space is so valuable such as in the top bar.

Sorry but at the moment the cases where actually notifications will show up there are so few that it doesn’t warrant showing a yet unneeded icon for an empty dropdown the whole time.

cc @karlitschek @owncloud/designers

@karlitschek
Copy link
Contributor

No strong opinions here from me. I can see the point that we shouldn't show an icon if it is of no use. On the other side websites like Facebook and Google+ show an notification icon even if nothing is there.
So both is fine with me.

@jancborchardt
Copy link
Member Author

Yeah, I was thinking about the other websites as well. But they definitely have more cases where notifications are shown.

So as of now I would still say we should only show the icon when there are notifications. Once there are more cases where there can be notifications, we could show it permanently. We can revisit that for 9.2 or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants