This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Better interfaces #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
refs
commented
Feb 4, 2020
refs
commented
- micro store interface does not really match our needs so we defined our own
- accounts service definition in protobuf
- micro cli@v2
tboerger
reviewed
Feb 4, 2020
| func Server() cli.Command { | ||
| return cli.Command{ | ||
| func Server(cfg *config.Config) *cli.Command { | ||
| baseDir, _ := filepath.Abs(filepath.Dir(os.Args[0])) |
There was a problem hiding this comment.
PLEASE NEVER do such a stupid default, it should be NEVER in the same dir as the binary.
There was a problem hiding this comment.
Yeah, not happy about this one. What would you set as a default location that works in different OS? 🤔
There was a problem hiding this comment.
This depends on the user AND the os. Not sure if a default is that great at all.
There was a problem hiding this comment.
Actually no default is better, since different implementations might not care about this path.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.