inconsequent labels in deployments

[genofire]

in selector should be the helper be used

• e.g. if you like to run multiple helm charts in the same namespace.
• clean labeling like from helm introduced: helm create

 {{- $_ := set . "appName" "users" -}}
 {{- $_ := set . "resources" (default (default (dict)  .Values.resources) .Values.services.users.resources) -}}
 apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: {{ .appName }}
   namespace: {{ template "ocis.namespace" . }}
   labels:
     {{- include "ocis.labels" . | nindent 4 }}
 spec:
   selector:
     matchLabels:
       app: {{ .appName }}
+      {{- include "ocis.selectorLabels" . | nindent 8 }}
   {{- if and (not .Values.autoscaling.enabled) (.Values.replicas) }}
   replicas: {{ .Values.replicas }}
   {{- end }}
   {{- if .Values.deploymentStrategy }}
   strategy: {{ toYaml .Values.deploymentStrategy | nindent 4 }}
   {{ end }}
   template:
     metadata:
       labels:
         app: {{ .appName }}
-        {{- include "ocis.labels" . | nindent 8 }}
+        {{- include "ocis.selectorLabels" . | nindent 8 }}

[wkloucek]

Thanks for opening this issue!

• running multiple helm charts in the same namespace overlaps with Use unique names -- include release name #140
• Eg. Grafana also distinguishes between labels and selector labels https://github.com/grafana/helm-charts/blob/76c7fbe1d9ac08775bf378ad7d448d4dd8533e44/charts/grafana/templates/deployment.yaml#L7-L34

[genofire]

1. Oh yeah, thanks for writting that issue.
2. podLabel maybe are there from interesting too (we use it for special networkpolicies - e.g. from prometheues reachable)