Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web concurrent share requests config #473

Closed
micbar opened this issue Jan 26, 2024 · 6 comments
Closed

Add web concurrent share requests config #473

micbar opened this issue Jan 26, 2024 · 6 comments
Assignees
Labels
Category:Enhancement Add new functionality Priority:p2-high Escalation, on top of current planning, release blocker

Comments

@micbar
Copy link
Contributor

micbar commented Jan 26, 2024

Description

As of ocis 5.0.0, web has a new setting which intends to reduce concurrency in sharing requests on very slow NFS storages.

Ocis PR: owncloud/ocis#8056
Web Ticket: owncloud/web#10227

@kulmann @JammingBen May I ask you to take care of that and assign one of you to that ticket?

@micbar
Copy link
Contributor Author

micbar commented Jan 26, 2024

@wkloucek @d7oc FYI

@wkloucek wkloucek self-assigned this Jan 29, 2024
@wkloucek wkloucek added Category:Enhancement Add new functionality Priority:p2-high Escalation, on top of current planning, release blocker labels Jan 29, 2024
@wkloucek
Copy link
Contributor

@micbar In #474 I tried to use these settings.

I could get WEB_OPTION_CONCURRENT_REQUESTS_RESOURCE_BATCH_ACTIONS and WEB_OPTION_CONCURRENT_REQUESTS_SSE to work (I see them beeing reflected on the /config.json endpoint)

But for WEB_OPTION_CONCURRENT_REQUESTS_SHARES_CREATE and WEB_OPTION_CONCURRENT_REQUESTS_SHARES_LIST, I don't see an entry in /config.json tough I set them to 1, too,.

output of helmfile diff when setting those:

              - name: WEB_UI_THEME_SERVER
                value: https://ocis.kube.owncloud.test
+             - name: WEB_OPTION_CONCURRENT_REQUESTS_RESOURCE_BATCH_ACTIONS
+               value: "1"
+             - name: WEB_OPTION_CONCURRENT_REQUESTS_SSE
+               value: "1"
+             - name: WEB_OPTION_CONCURRENT_REQUESTS_SHARES_CREATE
+               value: "1"
+             - name: WEB_OPTION_CONCURRENT_REQUESTS_SHARES_LIST
+               value: "1"

              - name: WEB_UI_CONFIG_SERVER
                value: "https://ocis.kube.owncloud.test"

/config.json after deploying:

{
"server": "https://ocis.kube.owncloud.test/",
"theme": "https://ocis.kube.owncloud.test/themes/owncloud/theme.json",
"openIdConnect": {
"metadata_url": "https://ocis.kube.owncloud.test/.well-known/openid-configuration",
"authority": "https://ocis.kube.owncloud.test/",
"client_id": "web",
"response_type": "code",
"scope": "openid profile email"
},
"apps": [
"files",
"search",
"text-editor",
"pdf-viewer",
"external",
"admin-settings"
],
"external_apps": [
{
"id": "preview",
"path": "web-app-preview",
"config": {
"mimeTypes": [
"image/tiff",
"image/bmp",
"image/x-ms-bmp"
]
}
}
],
"options": {
"previewFileMimeTypes": [
"image/gif",
"image/png",
"image/jpeg",
"text/plain",
"image/tiff",
"image/bmp",
"image/x-ms-bmp",
"application/vnd.geogebra.slides"
],
"sharingRecipientsPerPage": 200,
"sidebar": {
"shares": {
"showAllOnLoad": false
}
},
"routing": {
"idBased": true
},
"contextHelpersReadMore": true,
"openLinksWithDefaultApp": true,
"tokenStorageLocal": true,
"concurrentRequests": {
"resourceBatchActions": 1,
"sse": 1
}
}
}

Could this be a bug in oCIS?

@micbar
Copy link
Contributor Author

micbar commented Jan 30, 2024

@wkloucek could be a bug. @JammingBen Should a backend engineer take over or would you like to continue?

@JammingBen
Copy link
Contributor

JammingBen commented Jan 30, 2024

I didn't find any time for this yesterday, but I can check now. I'll drop you a message if I need help from a backend engineer.

Edit: This should fix it: owncloud/ocis#8317

@wkloucek
Copy link
Contributor

wkloucek commented Feb 7, 2024

Guess it's done, but will only work properly with some release after oCIS 5.0.0-rc.3

@wkloucek wkloucek closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Priority:p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

No branches or pull requests

3 participants