Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Non-compliant mtime format in "getlastmodified" Webdav field #116

Closed
PVince81 opened this issue Mar 20, 2020 · 3 comments · Fixed by cs3org/reva#805
Closed

Non-compliant mtime format in "getlastmodified" Webdav field #116

PVince81 opened this issue Mar 20, 2020 · 3 comments · Fixed by cs3org/reva#805
Assignees

Comments

@PVince81
Copy link
Contributor

In Phoenix, the moment library complains that the returned format is not compliant:
image

The Webdav property getlastmodified must respect rfc1123: https://tools.ietf.org/html/rfc4918#section-15.7

I found something related here: https://stackoverflow.com/q/25658897

Apparently one cannot use "UTC" as a timezone there and should return either "UT" or "GMT".

@PVince81
Copy link
Contributor Author

@PVince81
Copy link
Contributor Author

PVince81 commented May 5, 2020

Either we pre-process it on the Phoenix side to avoid that warning, or we pre-process the values in ocdav before returning it. I'd be more in favor of the latter.

@PVince81
Copy link
Contributor Author

PVince81 commented Jun 5, 2020

I reread the linked ticket and apparently we should use RFC1123Z instead.

Here's a PR that does it cs3org/reva#805 and indeed fixes the format issue.

@PVince81 PVince81 self-assigned this Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant