Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

File list doesn't loads when a file contains & #122

Closed
dpakach opened this issue Mar 25, 2020 · 6 comments · Fixed by cs3org/reva#627, cs3org/reva#645 or owncloud/web#3463
Closed

File list doesn't loads when a file contains & #122

dpakach opened this issue Mar 25, 2020 · 6 comments · Fixed by cs3org/reva#627, cs3org/reva#645 or owncloud/web#3463
Assignees

Comments

@dpakach
Copy link
Contributor

dpakach commented Mar 25, 2020

Steps to reproduce

  1. Setup ocis-phoenix with ocis-reva backend
  2. upload some files eg .lorem.txt and new-lorem.txt
  3. Create a new file that contains & character in its name eg. &#

Result

The file gets created in the data folder but the file list is empty

description

The reason for this error seems to be because phoenix cannot parse the xml response from the webdav api when it contains such files.
If we have such file in the middle of the file list then some files show up in the list (the files that come before the one containing &) while the other files (the files that are after the one containing & in the list) are not shown.

This might be the problem with server as well since the server sent correct and parseable response before.

@dpakach
Copy link
Contributor Author

dpakach commented Mar 25, 2020

This part in the response seems to break the whole thing

 <d:href>/remote.php/webdav/&amp;%23</d:href>

@DeepDiver1975
Copy link
Member

Does this work with phoenix being connected to oc10?

@dpakach
Copy link
Contributor Author

dpakach commented Mar 26, 2020

@DeepDiver1975, It works with oc10. So might be a problem in the backend.

@DeepDiver1975
Copy link
Member

Yes. Lets move this to the ocis-reva backend

@DeepDiver1975 DeepDiver1975 transferred this issue from owncloud/ocis-phoenix Mar 26, 2020
@C0rby C0rby self-assigned this Apr 1, 2020
@individual-it
Copy link
Member

individual-it commented Apr 9, 2020

fix done (but not merged to this repo yet), need to add API tests

@individual-it
Copy link
Member

tests added in owncloud/core#37231

as the change is not in ocis / ocis-reva yet, the tests for ocis demonstrate the current buggy behaviour when the fix will be brought into ocis-reva and ocis, the tests will start failing and will have to be adjusted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants