-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing seems to work but does not work #1303
Comments
Even if the sharing looks good when we look at the |
need to re-check with EOS |
In OCIS the user first has to accept files that were shared.
The shared files can be listed. It looks like so:
To accept the share one has to send this request. But yes this is not implemented yet.
|
seems you missed adding I happened to have tried it with a non-existing request and it returns |
right, with ocfs it's not implemented:
|
I did implement a prototype but still need some feedback on it. |
Testing with EOS blocked by https://github.com/owncloud/ocis/issues/253 |
Issue : https://github.com/owncloud/ocis-reva/issues/260 is created since sharee gets information about |
Is that even necessary? |
I guess this "feature" is available in ownCloud10 - @jasson99 ? So a client app could do such a request and maybe expect to get just the already-filtered list of share(s) for the requested resource. So it depends how much of this detailed oC10 compatible behavior is to be strictly followed. |
with EOS accepting the share works and the receiver can see the share through the |
tests have been added, so I'm taking away the QA-team label. If more tests are needed please add the label again |
this also blocks running sharing tests on EOS, because the path where the shares are accessible are different to oc10, so ether we have to adjust the EOS settings or make the test-code smarter |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions. |
sharing works properly with
|
Sharing "seems" to work as expected, but resharing a received share does not work in OCIS. This is because the share does not exist for the receiver even if the response and the status code look good to sharer after sharing.
In OC10:
Alice
,Brian
andCarol
Alice
creates a folderTMP
Alice
shares folderTMP
with userBrian
:Brian
checks for the presence of received shareTMP
:Brian
shares received shareTMP
with userCarol
:In OCIS:
Alice
,Brian
andCarol
Alice
creates a folderTMP
Alice
makes sure for the presence of folderTMP
and PROPFIND works on both endpoints:Alice
shares folderTMP
with userBrian
:Alice
about the created share is:Brian
checks for the presence of received shareTMP
:Brian
shares the received shareTMP
with userCarol
:The text was updated successfully, but these errors were encountered: