Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a public link after renaming a file #1275

Closed
C0rby opened this issue Jun 29, 2020 · 7 comments
Closed

Deleting a public link after renaming a file #1275

C0rby opened this issue Jun 29, 2020 · 7 comments

Comments

@C0rby
Copy link
Contributor

C0rby commented Jun 29, 2020

tests/acceptance/features/apiSharePublicLink1/deletePublicLinkShare.feature:24
Deleting a public link after renaming a file is not working.

OCS status code is not the expected value 100 got 400
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'100'
        +'400'
@PVince81
Copy link
Contributor

please link with original ticket, etc

@C0rby
Copy link
Contributor Author

C0rby commented Jul 1, 2020

The PR with the changes to delete public links: cs3org/reva#899.
The PR in owncloud/core which activated the tests: owncloud/core#37608.

@PVince81
Copy link
Contributor

PVince81 commented Jul 3, 2020

can you clarify whether you meant that the problem is solved by your PRs or did you just discover it while testing that PR and still needs fixing ?

@C0rby
Copy link
Contributor Author

C0rby commented Jul 3, 2020

Ah yes sorry.
So I implemented the deletion of public links and after that activated the related tests.

Almost all scenarios worked except of this tests/acceptance/features/apiSharePublicLink1/deletePublicLinkShare.feature:24.
This still needs fixing. I was guessing that changing a file which was shared needs to be handled in the share handler but maybe that is not correct.

@PVince81
Copy link
Contributor

PVince81 commented Jul 6, 2020

@PVince81
Copy link
Contributor

PVince81 commented Jul 6, 2020

there is indeed a problem after renaming, so closing in favor of https://github.com/owncloud/ocis-reva/issues/335.

the only bug I'd see for deletion is if the error response is 400 bad request instead of 404 not found.

@butonic butonic transferred this issue from owncloud/ocis-reva Jan 18, 2021
@refs refs changed the title [Public Link] Deleting a public link after renaming a file Deleting a public link after renaming a file Jan 18, 2021
@refs
Copy link
Member

refs commented Jan 18, 2021

continue in #1251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants