Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sciencemesh app does not select next client #10069

Closed
butonic opened this issue Sep 16, 2024 · 5 comments
Closed

sciencemesh app does not select next client #10069

butonic opened this issue Sep 16, 2024 · 5 comments
Assignees
Labels

Comments

@butonic
Copy link
Member

butonic commented Sep 16, 2024

the reva sciencemesh token.go only initializes a gateway client on service init:

type tokenHandler struct {
	gatewayClient    gateway.GatewayAPIClient
	meshDirectoryURL string
	providerDomain   string
	eventStream      events.Stream
}

func (h *tokenHandler) init(c *config) error {
	var err error
	h.gatewayClient, err = pool.GetGatewayServiceClient(c.GatewaySvc)
	if err != nil {
		return err
	}

	h.meshDirectoryURL = c.MeshDirectoryURL
	h.providerDomain = c.ProviderDomain

	if c.Events.Endpoint != "" {
		es, err := stream.NatsFromConfig("sciencemesh-token-handler", false, stream.NatsConfig(c.Events))
		if err != nil {
			return err
		}
		h.eventStream = es
	}

	return nil
}

this will cause requests to fail when the gateway service has moved to a diffferent ip

@butonic
Copy link
Member Author

butonic commented Sep 16, 2024

cc @d7oc

@d7oc
Copy link
Contributor

d7oc commented Sep 16, 2024

Log error message:

{
  "level": "error",
  "service": "ocm",
  "pkg": "rhttp",
  "traceid": "45b32da09e0900e6645e4033f1375cf4",
  "request-id": "3d6dd949-cdd6-4c23-99a4-72f4fcb48004",
  "error": "rpc error: code = Unavailable desc = gateway: error calling FindAcceptedUsers: rpc error: code = Unavailable desc = last connection error: connection error: desc = \"transport: Error while dialing: dial tcp 10.42.0.108:9282: connect: no route to host\"",
  "time": "2024-09-16T15:53:55Z",
  "line": "github.com/cs3org/reva/v2@v2.24.1/internal/http/services/reqres/reqres.go:64",
  "message": "error sending a grpc find accepted users request"
}

@d7oc
Copy link
Contributor

d7oc commented Sep 18, 2024

@butonic shouldn't this issue be on the infinite scale board?

@butonic butonic self-assigned this Sep 18, 2024
@butonic
Copy link
Member Author

butonic commented Sep 18, 2024

pr in cs3org/reva#4851

@butonic
Copy link
Member Author

butonic commented Sep 19, 2024

landed in ocis with #10102

@butonic butonic closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants