Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM. delete-accepted-user endpoint always returns 200 #10223

Open
Tracked by #9735
ScharfViktor opened this issue Oct 2, 2024 · 3 comments
Open
Tracked by #9735

OCM. delete-accepted-user endpoint always returns 200 #10223

ScharfViktor opened this issue Oct 2, 2024 · 3 comments
Labels

Comments

@ScharfViktor
Copy link
Contributor

Web UI 10.3.0
Ocis: 6.5.0

Steps:
Given using server "LOCAL"
And "Alice" has generated invitation
And using server "REMOTE"
And "Brian" has accepted invitation
And "Brian" deletes connection to user "Alice"

Actual: 200. Should be 204?

And "Brian" tries to delete connection to user "Alice" - or use random userId

Expected: bad request. user not found
Actual: 200

@2403905
Copy link
Contributor

2403905 commented Oct 24, 2024

If it is not deleteting the connection (#10216) may be better to return 405 or 501?

@rhafer
Copy link
Contributor

rhafer commented Oct 24, 2024

If it is not deleteting the connection (#10216) may be better to return 405 or 501?

Wouldn't it be a 404 (Not Found) when trying to delete a non-existing connection?

@anon-pradip
Copy link
Contributor

anon-pradip commented Feb 17, 2025

While deleting the non-existing user, in the request body:

  • If I change the idp to some random one or two digit number (like "idp":"localhost:33") then the server hangs up.
  • If I change the idp to some random three digit number (like: "idp":"localhost:333" then the status code is always 200.
  • If I change the idp to some random 4 digit number then the status code alternates between returning 200 and 400.

https://github.com/user-attachments/assets/645bbcff-5225-4050-8ba8-44711a532cb0
https://github.com/user-attachments/assets/47db0bdb-8376-4e1e-ae0b-5a36f10a3bcf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Prio 3 or less
Development

No branches or pull requests

4 participants