Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway Panics #10594

Closed
kobergj opened this issue Nov 18, 2024 · 1 comment
Closed

Gateway Panics #10594

kobergj opened this issue Nov 18, 2024 · 1 comment
Assignees
@kobergj
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@kobergj
Copy link
Collaborator

kobergj commented Nov 18, 2024

The gateway service panics when the reva token is not valid. This is because all grpc endpoints on gateway are unprotected.
Two steps to fix it properly:

  • Avoid calling ContextMustGetUser in gateway and call ContextGetUser instead. Return an error if the user is not available.
  • Adjust UnprotectedEndpoints method of gateway service to return only specific endpoints, not all of them (not in scope of this ticket)
@kobergj kobergj moved this from Qualification to Prio 2 in Infinite Scale Team Board Nov 18, 2024
@kobergj kobergj self-assigned this Nov 18, 2024
@kobergj kobergj moved this from Prio 2 to In progress in Infinite Scale Team Board Nov 18, 2024
@kobergj kobergj added the Priority:p2-high Escalation, on top of current planning, release blocker label Nov 18, 2024
@kobergj kobergj mentioned this issue Nov 18, 2024
Merged
@rhafer
Copy link
Contributor

rhafer commented Nov 20, 2024

@kobergj I guess this can be closed?

@kobergj kobergj closed this as completed Nov 21, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kobergj kobergj

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhafer @kobergj