Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB_OPTION_EMBED_ENABLED cannot be used because it's a string type #10724

Open
wkloucek opened this issue Dec 4, 2024 · 0 comments
Open

WEB_OPTION_EMBED_ENABLED cannot be used because it's a string type #10724

wkloucek opened this issue Dec 4, 2024 · 0 comments
Labels

Comments

@wkloucek
Copy link
Contributor

wkloucek commented Dec 4, 2024

Describe the bug

WEB_OPTION_EMBED_ENABLED cannot really be used.
It is a type string to allow an empty default!??

Whenever you set it to true or false, oC Web looks at the /config.json endpoint and sees a string type "true" or "false" and errors because it expects a bool type config option.

Steps to reproduce

  1. configure WEB_OPTION_EMBED_ENABLED to any bool-ish string
  2. try to load oC Web

Expected behavior

See oC Web being usable and using the configuration from WEB_OPTION_EMBED_ENABLED

Actual behavior

See oC Web failing to load and complaining about the non-bool type config option in the DEV console

Setup

I found that with oCIS 7.0.0-rc.3

cc @kulmann @JammingBen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant