Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to access another users folder from propfind gives internal server error #1272

Closed
dpakach opened this issue Jun 26, 2020 · 2 comments
Closed
Labels

Comments

@dpakach
Copy link
Contributor

dpakach commented Jun 26, 2020

according to owncloud/ocis-reva#9 users can access another users dav endpoints which is a bug. but in EOS storage if a user tries to access another user's file he gets similar result.
But when accessing another users folder it gives 500 - Internal Server Error
While this should not be allowed, it should gives proper status code and message like 403

@butonic butonic transferred this issue from owncloud/ocis-reva Jan 18, 2021
@refs refs changed the title [EOS] Trying to access another users folder from propfind gives internal server error Trying to access another users folder from propfind gives internal server error Jan 18, 2021
@settings settings bot removed the Storage:EOS label Jan 29, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@butonic
Copy link
Member

butonic commented Nov 7, 2022

To clarify: the spaces concept allow acessing other users spaces at the /dav/spaces/{spaceid} endpoint. Accessing other users spaces at /dav/files/{username} only makes sense if te space belongs to a technical user that shared his root to multiple users or a group. A workaround for old project drive like functionality. Spaces adresses that properly.

That being said, The /dav/files/{username} endpoint should return 404 to not leak if a user exists or not. See #3872

The ocdav handler currently checks if the logged in user matches the username in the path, regardless of storage driver and returns whatever error code is returned by the storage driver.

@fschade
Copy link
Contributor

fschade commented Jun 4, 2024

Please open again if the ticket is still relevant

@fschade fschade closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants