Weird version semantics

[PVince81]

In other modules like ocis-settings, we are importing the so-called v2 of ocis-pkg as github.com/owncloud/ocis-pkg/v2 v2.2.2-0.20200812103920-db41b5a3d14d (when using go get with @master)

However the commit "db41b5a3d14d" is on master, and not on the "v2" branch.
And the "v2" branch seems much older than master.

Is this intended ? What is the purpose of the "v2" branch then ?
And where is the old v1 version then ?

@butonic @refs

[refs]

v2 should act as master. As per go modules docs:

The recommended strategy is to develop v2+ modules in a directory named after the major version > suffix.

github.com/googleapis/gax-go @ master branch
/go.mod → module github.com/googleapis/gax-go
/v2/go.mod → module github.com/googleapis/gax-go/v2

However we're not versioning on a version folder, instead on a branch. When that's the case:

Other strategies may keep major versions on separate branches. However, if v2+ source code is on the repository's default branch (usually master), tools that are not version-aware — including the go command in GOPATH mode — may not distinguish between major versions.

To my understanding we have to rebase master onto v2.

[PVince81]

yeah, because recently we updated using @master so I'm worried that we might have the wrong code.

however I saw that @butonic has pushed to ocis-pkg master, so probably that one is still the one we consider "the right one"

[refs]

@PVince81 owncloud/ocis-pkg#54. For the future, after all this release party.

[phil-davis]

@refs this is an old issue that was transferred from the archived ocis-pkg repo a few weeks ago.
Please close if no longer relevant.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.