Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPTION request for TUS upload does not have checksum headers in it's response #1747

Closed
swoichha opened this issue Mar 2, 2021 · 1 comment
Labels
OCIS-Fastlane Planned outside of the sprint Type:Bug

Comments

@swoichha
Copy link
Contributor

swoichha commented Mar 2, 2021

Describe the bug

Although PR cs3org/reva#1400 has implemented checksumming for TUS uploads its not advertised in the TUS headers.

According to the TUS checksum extension description in https://tus.io/protocols/resumable-upload.html#checksum when an OPTION request is send to an endpoint then it should contain Tus-Extension: checksum and Tus-Checksum-Algorithm: md5,sha1,crc32 in its response.

Steps to reproduce

Steps to reproduce the behavior:

  1. Send OPTION request to endpoint https://localhost:9200/remote.php/dav/files/Einstein/
  • curl -X OPTIONS https://localhost:9200/remote.php/dav/files/Einstein/ -k -v

Expected behavior

Something like this

HTTP/1.1 204 No Content
Tus-Resumable: 1.0.0
Tus-Version: 1.0.0
Tus-Extension: checksum
Tus-Checksum-Algorithm: md5,sha1,crc32

Actual behavior

HTTP/1.1 200 OK
Access-Control-Allow-Headers: Tus-Resumable
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Tus-Resumable, Tus-Version, Tus-Extension
Allow: OPTIONS, LOCK, GET, HEAD, POST, DELETE, PROPPATCH, COPY, MOVE, UNLOCK, PROPFIND, MKCOL, REPORT, SEARCH, PUT
Content-Length: 0
Content-Security-Policy: default-src 'none';
Content-Type: application/xml
Date: Tue, 02 Mar 2021 08:25:28 GMT
Dav: 1, 2
Ms-Author-Via: DAV
Tus-Extension: creation,creation-with-upload
Tus-Resumable: 1.0.0
Tus-Version: 1.0.0
@exalate-issue-sync
Copy link

David Christofas commented: PR was merged in reva.
Still need the reva update in ocis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCIS-Fastlane Planned outside of the sprint Type:Bug
Projects
None yet
Development

No branches or pull requests

2 participants