Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reva Gateway Address Configuration #2091

Closed
refs opened this issue May 27, 2021 · 0 comments · Fixed by #2587
Closed

Reva Gateway Address Configuration #2091

refs opened this issue May 27, 2021 · 0 comments · Fixed by #2587

Comments

@refs
Copy link
Member

refs commented May 27, 2021

There is a pattern that is increasing code entropy quite a bit: every struct field is configurable through an environment variable (following the 12-factor App manifesto)

We are currently however at a case where we need to mint jwt tokens outside Reva and the same configuration leaks to outside services. The most recent example is seen here. The problem in turn is this line:

EnvVars:     []string{"WOPISERVER_REVA_GATEWAY"},

Similar other extensions define their own names for what it essentially is the same value (that is, if run in the same vm):

grafik

Proposed solutions

  1. Adopt the same name for all services that need to know about the reva gateway address.
  2. Make better use the service registry to fetch the address of the reva gateway.
  3. Agree on a naming scheme (i.e: let extensions define their EXTENSION_REVA_GATEWAY_ADDR variables and add REVA_GATEWAY as a fallback to configure all extensions at one, similar to OCIS_URL).

For more context, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant