Cannot reliably determine ocis version

[jnweiger]

To compare test results across systems, I need to know which version was started.

I am starting three different systems via https://github.com/owncloud-docker/compose-playground/tree/master/examples/hetzner-deploy

env OCIS_VERSION=v1.0.0-beta4 ./make_ocis_eos_compose_test.sh
env OCIS_VERSION=v1.0.0-beta5 ./make_ocis_eos_compose_test.sh
env OCIS_VERSION=master ./make_ocis_eos_compose_test.sh

When logged in to the web UI

beta4 reports:

beta5 and master report:

On the console we get:

root@jw-ocis-v1-0-0-beta4-eos-compose-lo-z3af1:~/compose-playground/examples/eos-compose# docker exec ocis ocis --version
ocis version 0.0.0

root@jw-ocis-v1-0-0-beta5-eos-compose-lo-z3af1:~/compose-playground/examples/eos-compose# docker exec ocis ocis --version
ocis version 0.0.0

root@jw-ocis-master-eos-compose-lo-z3af1:~/compose-playground/examples/eos-compose# docker exec ocis ocis --version
ocis version 0.0.0

[jnweiger]

Re-Tested with the docker image owncloud/ocis:1.0.0-beta8

It shows the correct version number with the ocis --version command, but shows a wrong version number in status.php:

$ docker exec -ti vigorous_noether ocis --version
ocis version 1.0.0-beta8

$ curl -k https://localhost:9200/status.php
{
    "installed": true,
    "maintenance": false,
    "needsDbUpgrade": false,
    "version": "10.0.9.5",
    "versionstring": "10.0.9",
    "edition": "community",
    "productname": "ownCloud"
}

Failed to find a version number in the phoenix web gui.

expected behaviour:

• version numbers of ocis (and phoenix?) are avialable in status.php
• and in the web gui.

Reproduced in #1127
on ocis1.0.0-rc8 deploed via ocis/deployments/examples/ocis_traefik/

[jnweiger]

Re-tested with rc1 docker. No version info can be found any more in the web gui. Status php unchanged. Same wrong numbers as above.

Expected behaviour:

• see ocis version, phoenix version, maybe eos version, ...
• version numbers in status.php reflect real product versions, or is at least a higher number than any released oc10.

[jnweiger]

This is a followup on owncloud/web#1294

[jnweiger]

rc1 docker has

# strings /usr/bin/ocis | grep 'owncloud/ocis-.*@v' | sed -e 's@.*/owncloud/@\towncloud/@' -e 's%\(@v[^/]*\).*%\1%' | sort -u
	owncloud/ocis-accounts@v0.4.2-0.20200901074457-6a27781a2741
	owncloud/ocis-glauth@v0.5.1-0.20200731165959-1081de7c60f1
	owncloud/ocis-graph-explorer@v0.0.0-20200210111049-017eeb40dc0c
	owncloud/ocis-graph@v0.0.0-20200318175820-9a5a6e029db7
	owncloud/ocis-hello@v0.1.0-alpha1.0.20200828085053-37fcf3c8f853
	owncloud/ocis-konnectd@v0.3.2
	owncloud/ocis-migration@v0.2.0
	owncloud/ocis-ocs@v0.3.1
	owncloud/ocis-phoenix@v0.13.0
	owncloud/ocis-pkg/v2@v2.4.1-0.20200828095914-d3b859484b2b
	owncloud/ocis-proxy@v0.7.1-0.20200904132806-fcceec602fcb
	owncloud/ocis-reva@v0.13.0
	owncloud/ocis-settings@v0.3.2-0.20200902094647-35dc3aeaba78
	owncloud/ocis-store@v0.1.1
	owncloud/ocis-thumbnails@v0.3.0
	owncloud/ocis-webdav@v0.1.1

I'd hoped to see phoenix v0.16.0 there - that is what the phoenix CHANGLOG.md has... 🤔

[jnweiger]

HTTP headers convey a phoenix version number. It seems to be wrong: #531

[micbar]

Fixed with #609

[jnweiger]

docker-compose -f master-docker-compose-eos-test.yml exec ocis ocis proxy version

+---------+-----------------+--------------------------------------+
| Version |     Address     |                  Id                  |
+---------+-----------------+--------------------------------------+
| 0.0.0   | 172.23.0.4:9200 | 602981e5-fe3a-4bd7-9aa9-6affce0dab23 |
+---------+-----------------+--------------------------------------+

@C0rby @micbar
From reading the source, I figured out the above. But it does not return anything useful.
Can you give the correct command line example, please? Or URL of the metrics endpoint...

I'd like to replace my current hack strings /usr/local/bin/ocis | grep '^dep\s.*owncloud' | sort -u

[jnweiger]

With RC6, my hack produces

OCIS_VERSION:         v1.0.0-rc6
ocis --version:       ocis version 0.0.0
git log:              commit 441bded50fbb1c0990306a4a791fde38cb1d25d5 (HEAD, tag: refs/tags/v1.0.0-rc6)
eos --version:        EOS 4.6.5 (2019)
xrootd -v:            v4.11.0
/usr/local/bin/ocis contains:
dep	github.com/owncloud/ocis-graph	v0.0.0-20200318175820-9a5a6e029db7	h1:gT0GyIOoR7XtpZ7sIxVJSckcz/nueGB1Cm1xNaflXQ0=
dep	github.com/owncloud/ocis-graph-explorer	v0.0.0-20200210111049-017eeb40dc0c	h1:8g3u2JwOMP/UE+0B+YjV7UWEQzyCPbnZzwIto6lNc0I=
dep	github.com/owncloud/ocis-hello	v0.1.0-alpha1.0.20200828085053-37fcf3c8f853	h1:ei0C5Wmppw+9oiSB0XpAdwymD8+ZnmewNdVVzYE3UvQ=
dep	github.com/owncloud/ocis/accounts	v0.5.3-0.20201103104733-ff2c41028d9b
dep	github.com/owncloud/ocis/glauth	v0.0.0-00010101000000-000000000000
dep	github.com/owncloud/ocis/konnectd	v0.0.0-00010101000000-000000000000
dep	github.com/owncloud/ocis/ocis-phoenix	v0.0.0-00010101000000-000000000000
dep	github.com/owncloud/ocis/ocis-pkg	v0.1.0
dep	github.com/owncloud/ocis/ocs	v0.0.0-00010101000000-000000000000
dep	github.com/owncloud/ocis/proxy	v0.0.0-00010101000000-000000000000
dep	github.com/owncloud/ocis/settings	v0.0.0-20200918114005-1a0ddd2190ee
dep	github.com/owncloud/ocis/storage	v0.0.0-20201015120921-38358ba4d4df
dep	github.com/owncloud/ocis/store	v0.0.0-20200918125107-fcca9faa81c8
dep	github.com/owncloud/ocis/thumbnails	v0.1.6
dep	github.com/owncloud/ocis/webdav	v0.0.0-00010101000000-000000000000

Ca. 10 objects just have v0.0.0 -- BAD.
There is no reva version number detctable. - BAD
(we seem not to be on the latest reva, as per #997 (comment))

[C0rby]

How is the ocis binary compiled? The 0.0.0 version indicates that the version information was not passed during compilation.

[dragotin]

The status.php is still not correct. See #1127