Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth: 0 propfind on https://ocis.owncloud.com/remote.php/webdav/ returns multiple items, when Shares exist #3704

Closed
TheOneRing opened this issue May 5, 2022 · 6 comments
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Status:Needs-Info Type:Bug

Comments

@TheOneRing
Copy link
Contributor

When performing a Depth: 0 propfind on the legacy endpoint, with existing shares, we get multiple items reported back.

Expected:
The response is supposed to report a single item.

05-05 17:13:19:550 [ info sync.httplogger ]:	"a243a96f-3087-41eb-ba50-f4309be21bc7: Request: PROPFIND https://ocis.owncloud.com/remote.php/webdav/ Header: { Depth: 0, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Windows) mirall/2.11.0.0-git (ownCloud, windows-10.0.22000 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Content-Type: text/xml; charset=utf-8, X-Request-ID: a243a96f-3087-41eb-ba50-f4309be21bc7, Original-Request-ID: a243a96f-3087-41eb-ba50-f4309be21bc7, Content-Length: 117, } Data: [<?xml version=\"1.0\" encoding=\"utf-8\"?><d:propfind xmlns:d=\"DAV:\"><d:prop><d:getlastmodified/></d:prop>M</d:propfind>\n]"
05-05 17:13:19:888 [ info sync.httplogger ]:	"a243a96f-3087-41eb-ba50-f4309be21bc7: Response: PROPFIND 207 https://ocis.owncloud.com/remote.php/webdav/ Header: { Access-Control-Allow-Origin: *, Access-Control-Expose-Headers: Tus-Resumable, Tus-Version, Tus-Extension, Content-Length: 534, Content-Security-Policy: default-src 'none';, Content-Type: application/xml; charset=utf-8, Date: Thu, 05 May 2022 15:13:22 GMT, Dav: 1, 3, extended-mkcol, Referrer-Policy: strict-origin-when-cross-origin, Strict-Transport-Security: max-age=315360000; preload, Tus-Extension: creation,creation-with-upload,checksum,expiration, Tus-Resumable: 1.0.0, Tus-Version: 1.0.0, X-Content-Type-Options: nosniff, X-Download-Options: noopen, X-Frame-Options: SAMEORIGIN, X-Permitted-Cross-Domain-Policies: none, X-Robots-Tag: none, X-Xss-Protection: 0, } Data: [
<d:multistatus xmlns:s=\"http://sabredav.org/ns\" xmlns:d=\"DAV:\" xmlns:oc=\"http://owncloud.org/ns\"><d:response><d:href>/remote.php/webdav/</d:href><d:propstat><d:prop><d:getlastmodified>Thu, 05 May 2022 15:12:56 GMT</d:getlastmodified></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/webdav/Shares/</d:href><d:propstat><d:prop><d:getlastmodified>Thu, 05 May 2022 15:12:29 GMT</d:getlastmodified></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response></d:multistatus>
]"
@TheOneRing
Copy link
Contributor Author

@butonic

@micbar micbar added the Priority:p3-medium Normal priority label May 10, 2022
@butonic butonic assigned butonic and unassigned butonic May 24, 2022
@butonic butonic added Priority:p2-high Escalation, on top of current planning, release blocker and removed Priority:p3-medium Normal priority labels May 24, 2022
@micbar
Copy link
Contributor

micbar commented May 27, 2022

cannot reproduce with 2.0.0-beta2

@C0rby C0rby self-assigned this May 30, 2022
@C0rby
Copy link
Contributor

C0rby commented May 30, 2022

Also can't reproduce with current master. I'll close this for now but it can be reopened if it happens again.

@C0rby C0rby closed this as completed May 30, 2022
@TheOneRing
Copy link
Contributor Author

{
    "installed": true,
    "maintenance": false,
    "needsDbUpgrade": false,
    "version": "10.11.0.0",
    "versionstring": "10.11.0",
    "edition": "Community",
    "productname": "Infinite Scale",
    "product": "Infinite Scale",
    "productversion": "2.0.0-beta2+794db9548"
}
05-31 13:13:43:574 [ info sync.httplogger ]:	"27a6f89c-b2f3-49ca-b663-0a749e3d808b: Request: PROPFIND https://ocis.owncloud.test/remote.php/webdav/ Header: { Depth: 0, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Macintosh) mirall/3.0.0.0-git (ownCloud, osx-21.4.0 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Content-Type: text/xml; charset=utf-8, X-Request-ID: 27a6f89c-b2f3-49ca-b663-0a749e3d808b, Original-Request-ID: 27a6f89c-b2f3-49ca-b663-0a749e3d808b, Content-Length: 117, } Data: [<?xml version=\"1.0\" encoding=\"utf-8\"?><d:propfind xmlns:d=\"DAV:\"><d:prop><d:getlastmodified/></d:prop>M</d:propfind>\n]"



05-31 13:13:43:625 [ info sync.httplogger ]:	"27a6f89c-b2f3-49ca-b663-0a749e3d808b: Response: PROPFIND 207 https://ocis.owncloud.test/remote.php/webdav/ Header: { Access-Control-Allow-Origin: *, Access-Control-Expose-Headers: Tus-Resumable, Tus-Version, Tus-Extension, Content-Length: 534, Content-Security-Policy: default-src 'none';, Content-Type: application/xml; charset=utf-8, Date: Tue, 31 May 2022 11:13:43 GMT, Dav: 1, 3, extended-mkcol, Tus-Extension: creation,creation-with-upload,checksum,expiration, Tus-Resumable: 1.0.0, Tus-Version: 1.0.0, X-Content-Type-Options: nosniff, X-Download-Options: noopen, X-Frame-Options: SAMEORIGIN, X-Permitted-Cross-Domain-Policies: none, X-Robots-Tag: none, X-Xss-Protection: 1; mode=block, } Data: [<d:multistatus xmlns:s=\"http://sabredav.org/ns\" xmlns:d=\"DAV:\" xmlns:oc=\"http://owncloud.org/ns\"><d:response><d:href>/remote.php/webdav/</d:href><d:propstat><d:prop><d:getlastmodified>Tue, 31 May 2022 11:05:46 GMT</d:getlastmodified></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response><d:response><d:href>/remote.php/webdav/Shares/</d:href><d:propstat><d:prop><d:getlastmodified>Tue, 31 May 2022 11:05:46 GMT</d:getlastmodified></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response></d:multistatus>]"

@TheOneRing TheOneRing reopened this May 31, 2022
@butonic
Copy link
Member

butonic commented Jun 1, 2022

@micbar this smells related to cs3org/reva#2907

@butonic
Copy link
Member

butonic commented Jun 8, 2022

fixed with #3932

@butonic butonic closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Status:Needs-Info Type:Bug
Projects
Archived in project
Development

No branches or pull requests

4 participants