settings service: storage-system configuration

[wkloucek]

Describe the bug

When I want to configure the setting service to use the storage-system service as a backend and they do not run on the same machine (same localhost), I cannot use default values and need to change following values:

STORAGE_GATEWAY_GRPC_ADDR and STORAGE_GRPC_ADDR both need to point to the GRPC endpoint of the storage-system service.

Expected behavior

There is one setting that needs to be pointed to the GRPC endpoint of the storage-system service.

The environment variable to do so starts with SETTINGS_ and has a similar naming as other services that use the storage-system, eg: SHARING_USER_CS3_PROVIDER_ADDR

Actual behavior

There are two values that I need to configure. Both start with STORAGE_

[micbar]

@wkloucek Is this a GA release blocker?

[wkloucek]

@wkloucek Is this a GA release blocker?

No I don't thinks so. Just a configuration quirk

[wkloucek]

the user facing configuration quirk is fixed with the switch to service names in 3.1.0-next.1, but the duplicated default value still persists:

ocis/services/settings/pkg/config/defaults/defaultconfig.go

Lines 56 to 57 in 447b111

	GatewayAddress: "com.owncloud.api.storage-system",
	StorageAddress: "com.owncloud.api.storage-system",