Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-oc-mtime header is not being respected in tus requests #4559

Closed
JammingBen opened this issue Sep 12, 2022 · 5 comments
Closed

x-oc-mtime header is not being respected in tus requests #4559

JammingBen opened this issue Sep 12, 2022 · 5 comments
Labels

Comments

@JammingBen
Copy link
Contributor

JammingBen commented Sep 12, 2022

Describe the bug

owncloud/web#7630 includes the x-oc-mtime header in XHR and tus upload requests. While XHR works fine, it seems that the header has no effect for tus requests.

Steps to reproduce

Steps to reproduce the behavior:

  1. Get Web running with current master
  2. Upload a file that has been modified a few days ago

Expected behavior

The "modified column" should show the proper modified date.

Actual behavior

It shows "0 seconds ago".

@micbar
Copy link
Contributor

micbar commented Sep 14, 2022

@JammingBen

From my POV i see no x-oc-mtime header sent by the web client during tus uploads. I see a big combined header with upload metadata

@JammingBen
Copy link
Contributor Author

@micbar Are you sure you have Web with current master running? The x-oc-mtime header should be available. Or does oCIS expect it to be received otherwise, maybe somehow included in Upload-Metadata?

image

@micbar
Copy link
Contributor

micbar commented Sep 14, 2022

As far as I read the code, a non-tus request works with the x-oc-mtime header and tus requests expect the mtime in the upload metadata.

@JammingBen Happy to check that out together with you

@JammingBen
Copy link
Contributor Author

tus requests expect the mtime in the upload metadata.

Ahh I didn't know this. Let me try it out, I'll come back to you 👍

@JammingBen
Copy link
Contributor Author

Yessss, adding mtime in upload metadata solved it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants