You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This seems a "won't fix", at least from OCIS' side.
As far as I know, go doesn't support conditional import neither dynamic loading. The only viable option I think we have is to use conditional compiling with build tags, but we'd need to generate 2 different executables: one with the import and another without it. This sounds inconvenient for the user, and it will add a lot of maintenance burden on our side.
Maybe we are just building it wrong? If we would build services individually we would not have this problem. Also binary sizes would be much smaller. We would just need to make the single binary optionally (or get rid of it at all...)
Describe the bug
Start a service (except search). Have a look at the goroutines.
Steps to reproduce
Steps to reproduce the behavior:
Expected behavior
See no bleve goroutines
Actual behavior
See bleve goroutines
Additional context
Bleve analyzer use an init() function to register themselves (eg. https://github.com/blevesearch/bleve/blob/20e6eb5564e5c94478c865c6e03944882c7a886c/analysis/analyzer/keyword/keyword.go#L36-L38)
We import it through our config / command setup in the single binary, so it always started. Even if we just start one service (not using bleve).
The text was updated successfully, but these errors were encountered: