Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space tag search broken #5323

Closed
fschade opened this issue Jan 4, 2023 · 6 comments
Closed

Space tag search broken #5323

fschade opened this issue Jan 4, 2023 · 6 comments
Assignees
Labels

Comments

@fschade
Copy link
Contributor

fschade commented Jan 4, 2023

Describe the bug

When searching for tags inside a space the result set is empty

Steps to reproduce

Steps to reproduce the behavior:

  1. create space
  2. upload resource
  3. tag resource
  4. click tag

Expected behavior

the tagged resource should be listen in the ui.

Actual behavior

no results found

@fschade fschade self-assigned this Jan 4, 2023
@fschade fschade changed the title Space Tags are broken Space tag search are broken Jan 4, 2023
@fschade fschade changed the title Space tag search are broken Space tag search broken Jan 4, 2023
@fschade
Copy link
Contributor Author

fschade commented Jan 4, 2023

the problem appears as soon as a group is a manager of a space, then the ev.SpaceOwner is the group and therefor can't be impersonated.

solutions:

  • introduce a service user (internal super user)
  • dereference the group members and use the first valid user (reva event)
  • ignore groups and only allow valid users in the event (reva event)

the problem popped up in the tagging case, but can also apply to other areas too.... we need to check carefully!

@micbar lets discuss after tomorrows standup.

@micbar
Copy link
Contributor

micbar commented Jan 4, 2023

Good analysis.

Maybe @aduffeck has an idea.

@fschade
Copy link
Contributor Author

fschade commented Jan 4, 2023

@fschade
Copy link
Contributor Author

fschade commented Jan 4, 2023

maybe i was wrong above, the used owner seems to be the space id.... described in 3019, let’s discuss tomorrow

Bildschirm­foto 2023-01-04 um 17 01 51
Bildschirm­foto 2023-01-04 um 17 01 44

@fschade
Copy link
Contributor Author

fschade commented Jan 5, 2023

lets see what the ci is saying and if we opened a can of worms....
cs3org/reva#3583

@kobergj
Copy link
Collaborator

kobergj commented Feb 27, 2023

Closing this since corresponding PR is merged.

@kobergj kobergj closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants