New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listing spaces makes subsequent requests #6158

Closed

2 tasks done

butonic opened this issue Apr 26, 2023 · 2 comments

Closed

2 tasks done

listing spaces makes subsequent requests #6158

butonic opened this issue Apr 26, 2023 · 2 comments

Assignees

Labels

Topic:Performance Type:Bug

Member

butonic commented Apr 26, 2023 •

edited

Loading

The graph /me/drives endpoint makes a ListStorageSpaces call and then:

a GetQuota call in drives.go:getDriveQuota() which we should fetch with the ListStorageSpaces call
a GetPath and a Stat call in driveItems.go:getSpecialDriveItem when fetching getExtendedSpaceProperties which we should either cache or receive from the initial ListStorageSpace call as well.

Related

#4586 tries to make requests cheaper by making fetching the root optional. BUt we still need to make these requests cheap as desktop clients will poll this endpoint

The text was updated successfully, but these errors were encountered:

butonic added Type:Bug Topic:Performance labels

butonic added this to Infinite Scale Team Board

github-project-automation bot moved this to Qualification in Infinite Scale Team Board

micbar moved this from Qualification to In progress in Infinite Scale Team Board

micbar assigned butonic

Member Author

butonic commented May 15, 2023 •

edited

Loading

related:

Member Author

butonic commented May 15, 2023

closing as

quota is now sent and fetched in opaque,
special items are now cached until the root changes

butonic closed this as completed

github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment