Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The envvars added in 7544 need an update after they have been tested #7557

Open
mmattel opened this issue Oct 20, 2023 · 2 comments
Open

The envvars added in 7544 need an update after they have been tested #7557

mmattel opened this issue Oct 20, 2023 · 2 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented Oct 20, 2023

Referencing: Allow configuring storage registry with envvars

Just that this does not get forgotten because the comments are now "hard to find by merged":

  • Wondering what the defaults and possible values like driver or rule names could be...
    @dragotin once you are familiar with the new envvars, could you improve the description in a follow-up PR?

  • GATEWAY_STORAGE_REGISTRY_CONFIG_JSON
    Q: how does the json get assigned to the variable? Imho a reference to a file would do this.
    See: USERS_LDAP_CACERT where we have a default path/file if not otherwise defined: If not defined, the root directory derives from $OCIS_BASE_DATA_PATH:/idm. Just my 2c.

Maybe to add the findings in this issue for a follow up PR to be created.

@kobergj @dragotin

@mmattel
Copy link
Contributor Author

mmattel commented Oct 20, 2023

Because GATEWAY_STORAGE_REGISTRY_RULES is new and an array, we need to add this to:
Fix wrong envvar descriptions when array strings are used

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant