Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated sidebar entries on the Phoenix UI #930

Closed
butonic opened this issue Nov 23, 2020 · 9 comments · Fixed by owncloud/web#4382
Closed

Duplicated sidebar entries on the Phoenix UI #930

butonic opened this issue Nov 23, 2020 · 9 comments · Fixed by owncloud/web#4382
Labels

Comments

@butonic
Copy link
Member

butonic commented Nov 23, 2020

(The issue also impacts the number of network requests made from Phoenix)

This issue does not occur with owncloud/ocis:1.0.0-beta8

@kulmann
Copy link
Member

kulmann commented Nov 23, 2020

Saw this happening before, when there was an error page after the login. Might be that the app is initialized twice in that case. Needs investigation.

@butonic
Copy link
Member Author

butonic commented Nov 23, 2020

@kulmann like this: #932 ?

@kulmann
Copy link
Member

kulmann commented Nov 23, 2020

@kulmann like this: #932 ?

@butonic yes, that's exactly what I meant.

@IljaN
Copy link
Member

IljaN commented Nov 23, 2020

AFAIR we saw this in the bridge setup with a wrong "unauthenticated-policy". Bridge is not involved here right?

@exalate-issue-sync
Copy link

Benedikt Kulmann commented: This happens when one of the extension paths defined in the config.json has a 404.
Steps to reproduce:

  1. create a proxy.json config file, but delete the endpoints for accounts.js or settings.js (or both).
  2. clear browser/application cache
  3. reload the page
  4. check that the requests to accounts.js or settings.js failed
  5. open the right sidebar on a resource. The accordion items People and Links are duplicated. Weird finding: Actions is not duplicated.

@kulmann
Copy link
Member

kulmann commented Nov 24, 2020

The issue was that in case of failing to load an extension, we were re-triggering loading all extensions, just without the failing one. The problem with this is, that the already successfully loaded extensions are loaded again then. While this is not an issue with the vuex store, it was re-adding all routes of the extensions, causing duplicate routes.

As a quick win we introduced that you can now define a default extension in the config.json by setting options.defaultExtension. It defaults to the files extension. The first route of the extension will be picked as home route.

@butonic
Copy link
Member Author

butonic commented Nov 25, 2020

fix landed in ocis with #943

@exalate-issue-sync exalate-issue-sync bot reopened this Dec 8, 2020
@exalate-issue-sync
Copy link

Benedikt Kulmann commented: [~mbarz] what's the reason for reopening this? Fix is in phoenix and ocis. Where/how did it reappear?

@kulmann
Copy link
Member

kulmann commented Dec 8, 2020

Closing again. Reopening happened by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants