Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit possible without permission in link share by uploading file with same name. #9322

Closed
JustKiddingCode opened this issue Jun 4, 2024 · 5 comments
Labels

Comments

@JustKiddingCode
Copy link

Describe the bug

In a link share scenario with "Can upload" permission, edits of files are still possible.
The Webui even asks to keep both, or replace.
So edit is possible by downloading and then uploading again.

Steps to reproduce

  1. Create Folder
  2. Create Share with Link with "Can upload permission"
  3. Using the link, Upload file "foo.txt" content "foo"
  4. Using same link (potentially different browser), upload file "foo.txt" content "bar"

Expected behavior

Uploading file with same name shouldn't be possible.

Actual behavior

foo.txt gets overwritten with content "bar"

Extra Information

#8435 seems related to this issue.

@rhafer
Copy link
Contributor

rhafer commented Jun 5, 2024

Actually what you describe is the expected behavior of "Can upload". If you want to prevent that you'd need to use the "Secret File Drop" permission.

@rhafer rhafer closed this as completed Jun 5, 2024
@micbar
Copy link
Contributor

micbar commented Jun 5, 2024

duplicate of owncloud/web#11381

@micbar
Copy link
Contributor

micbar commented Jun 5, 2024

We are working on changing the wording in the role description.

@JustKiddingCode
Copy link
Author

Actually what you describe is the expected behavior of "Can upload". If you want to prevent that you'd need to use the "Secret File Drop" permission.

So there's no permission set for an append-only share?

@micbar
Copy link
Contributor

micbar commented Jun 5, 2024

Correct. All files and new file versions are „uploads“.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants