Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include spaces etags in drives listing #3267

Merged
merged 1 commit into from
Mar 4, 2022
Merged

include spaces etags in drives listing #3267

merged 1 commit into from
Mar 4, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Mar 4, 2022

Added etags in the response of list drives.

Example response:

{
    "value": [
        {
            "driveType": "public",
            "id": "7993447f-687f-490d-875c-ac95e89a62a4",
            "lastModifiedDateTime": "1970-01-01T01:00:00+01:00",
            "name": "Public shares",
            "root": {
                "id": "7993447f-687f-490d-875c-ac95e89a62a4!7993447f-687f-490d-875c-ac95e89a62a4",
                "webDavUrl": "https://localhost:9200/dav/spaces/7993447f-687f-490d-875c-ac95e89a62a4"
            }
        },
        {
            "driveType": "personal",
            "id": "ddc2004c-0977-11eb-9d3f-a793888cd0f8",
            "lastModifiedDateTime": "2022-03-03T11:33:39.81499861+01:00",
            "name": "Admin",
            "owner": {
                "user": {
                    "id": "ddc2004c-0977-11eb-9d3f-a793888cd0f8"
                }
            },
            "quota": {
                "remaining": 297848631296,
                "state": "normal",
                "total": 297848661180,
                "used": 29884
            },
            "root": {
                "eTag": "\"853fc6056d1620e4d19f22552f7b731f\"",
                "id": "ddc2004c-0977-11eb-9d3f-a793888cd0f8!ddc2004c-0977-11eb-9d3f-a793888cd0f8",
                "webDavUrl": "https://localhost:9200/dav/spaces/ddc2004c-0977-11eb-9d3f-a793888cd0f8"
            }
        },
        {
            "driveType": "project",
            "id": "8176459f-5b69-4685-be16-dbb839f745da",
            "lastModifiedDateTime": "2022-03-04T10:53:12.511024737+01:00",
            "name": "New space",
            "owner": {
                "user": {
                    "id": "ddc2004c-0977-11eb-9d3f-a793888cd0f8"
                }
            },
            "quota": {
                "remaining": 999999966,
                "state": "normal",
                "total": 1000000000,
                "used": 34
            },
            "root": {
                "eTag": "\"a1e76ae675c942bd9e1cd23c41960148\"",
                "id": "8176459f-5b69-4685-be16-dbb839f745da!8176459f-5b69-4685-be16-dbb839f745da",
                "permissions": [
                    {
                        "grantedTo": [
                            {
                                "user": {
                                    "id": "ddc2004c-0977-11eb-9d3f-a793888cd0f8"
                                }
                            }
                        ],
                        "roles": [
                            "manager"
                        ]
                    }
                ],
                "webDavUrl": "https://localhost:9200/dav/spaces/8176459f-5b69-4685-be16-dbb839f745da"
            },
            "special": [
                {
                    "eTag": "\"3fc3d2c3845cf334f123fe31fb4c6f9f\"",
                    "file": {
                        "mimeType": "text/markdown"
                    },
                    "id": "8176459f-5b69-4685-be16-dbb839f745da!ff5769be-65d2-406a-9158-335cdcbdb88f",
                    "lastModifiedDateTime": "2022-03-04T10:53:12.498234474+01:00",
                    "name": "readme.md",
                    "size": 34,
                    "specialFolder": {
                        "name": "readme"
                    },
                    "webDavUrl": "https://localhost:9200/dav/spaces/8176459f-5b69-4685-be16-dbb839f745da/.space/readme.md"
                }
            ]
        },
        {
            "driveType": "virtual",
            "id": "a0ca6a90-a365-4782-871e-d44447bbc668",
            "name": "Shares Jail",
            "quota": {
                "remaining": 0,
                "state": "exceeded",
                "total": 0,
                "used": 0
            },
            "root": {
                "id": "a0ca6a90-a365-4782-871e-d44447bbc668!a0ca6a90-a365-4782-871e-d44447bbc668",
                "webDavUrl": "https://localhost:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668"
            }
        }
    ]
}

@C0rby C0rby self-assigned this Mar 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

micbar
micbar approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have got 3 YESes 😄

@C0rby C0rby merged commit 78962ec into master Mar 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-etags branch March 4, 2022 14:05
ownclouders pushed a commit that referenced this pull request Mar 4, 2022
commit 78962ec
71e4d48 
Merge: 13600c2 66f4198
Author: David Christofas <dchristofas@owncloud.com>
Date:   Fri Mar 4 15:05:10 2022 +0100

    Merge pull request #3267 from owncloud/spaces-etags

    include spaces etags in drives listing
@micbar micbar mentioned this pull request Mar 29, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@kobergj kobergj kobergj approved these changes

@micbar micbar micbar approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@C0rby @micbar @kobergj @wkloucek