Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing via public link hangs silently if password complexity requirements aren't met #391

Open
nodens opened this issue Mar 27, 2023 · 1 comment

Comments

@nodens
Copy link

nodens commented Mar 27, 2023

Hi,

When trying to share a file via public link, and when password_policy is used to enforce a certain amount of complexity, sharing the file fails - as expected. However, the user isn't notified, the pop up just stays there until one click cancel.

If the password is empty, the user is told a password is required, but I guess that's from the core settings, not from password_policy app.

I see no error in owncloud.log.

Network tab in browser debug console shows a 403 on /ocs/v2.php/apps/files_sharing/api/v1/shares?format=json
(result of failing to comply with policy, I guess, so normal), and there is the following error in js console:

Uncaught TypeError: xhr.responseJSON is undefined
    error sharedialoglinkshareview.js:223
    Backbone 2
    jQuery 6
    Backbone 4
    _save sharedialoglinkshareview.js:208
    _onClickSave sharedialoglinkshareview.js:344
    Underscore 3
    jQuery 25
    message oc-dialogs.js:309
    jQuery 7
sharedialoglinkshareview.js:223:16
    error sharedialoglinkshareview.js:223
    Backbone 2
    jQuery 6
    Backbone 4
    _save sharedialoglinkshareview.js:208
    _onClickSave sharedialoglinkshareview.js:344
    Underscore 3
    jQuery 25
    message oc-dialogs.js:309
    jQuery 7

I'm really not comfortable enough with JS to check out in detail, but it seems there is something wrong with the way the result of failure is presented to the user?

Owncloud version: 10.11.0
Running on Debian 11 (Bullseye), with php 7.4 from https://deb.sury.org/

Password policy app version: 2.1.4 (from Marketplace).

Thanks!

@nodens
Copy link
Author

nodens commented Apr 11, 2023

gentle ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant