Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display files list only if there is at least one item #2745

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Display files list only if there is at least one item #2745

merged 1 commit into from
Jan 13, 2020

Conversation

LukasHirt
Copy link
Collaborator

Related Issue

How Has This Been Tested?

  • test environment: Manually
  • test case 1: Check console in all files page

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added the Status:Needs-Review Needs review from a maintainer label Dec 18, 2019
@LukasHirt LukasHirt self-assigned this Dec 18, 2019
@PVince81
Copy link
Contributor

Might overlap somehow with #1911 but would do for the short term

PVince81
PVince81 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt force-pushed the bugfix/observe-error branch 6 times, most recently from 429325e to ed463d6 Compare January 8, 2020 08:49
@LukasHirt
Copy link
Collaborator Author

Hmm, the error is still showing up when switching between different lists. Will investigate.

@LukasHirt
Copy link
Collaborator Author

Hmm, the error is still showing up when switching between different lists. Will investigate.

Found the issue. Was due to some troubles with the load of the folder. The mounted point was too late. It then got confused between wrong items. Solved with beforeMount.

@LukasHirt
Display files list only if there is at least one item
9c542bd 
Adjusted list container selector

Use table selector instead of tableContainer

Added list container

Use beforeMount to load folder
@LukasHirt
Copy link
Collaborator Author

@PVince81 Can you pls re-review? There is the change from mounted to beforeMount. Let me pls know if you're okay with that change.

PVince81
PVince81 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 0b150e0 into master Jan 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/observe-error branch January 13, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning related to virtual scroll
2 participants
@LukasHirt @PVince81