Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc-avatar shifts layout after loading #2921

Closed
PVince81 opened this issue Jan 28, 2020 · 1 comment · Fixed by #2927
Closed

oc-avatar shifts layout after loading #2921

PVince81 opened this issue Jan 28, 2020 · 1 comment · Fixed by #2927
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

Steps

  1. Create two users "user1" and "user2" without avatars
  2. Login as "user1"
  3. Open the collaborators panel for any resource
  4. Add a new collaborator
  5. Type "us" and observe closely the avatar in the autocomplete dropdown
  6. Select "user2" and confirm
  7. Open the collaborators panel again and observe closely the avatar in the collaborators list

Expected result

  • Only one spinner in place of the avatar while loading.
  • After the avatar placeholder appears, the layout must stay in place

Actual result

  • Two spinners appear above each other in place of the avatar
  • After the avatar placeholder appears, the layout is shifting slightly

Note that some random test failures exist in CI with the "iPhone" form factor as sometimes the avatar load timing is different and the container layout shifts before the test runner can click on a selected element.

Version

Phoenix master e0df137

It is possible that the issue is related to the component in ODS, but is not confirmed yet as ODS doesn't provide an example of the spinner.

@kulmann as discussed.

@PVince81 PVince81 added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels Jan 28, 2020
@PVince81 PVince81 mentioned this issue Jan 28, 2020
10 tasks
@PVince81
Copy link
Contributor Author

PR here: #2927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant