Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive files view has file names truncated #2998

Closed
PVince81 opened this issue Feb 11, 2020 · 4 comments · Fixed by #2999
Closed

Responsive files view has file names truncated #2998

PVince81 opened this issue Feb 11, 2020 · 4 comments · Fixed by #2999
Assignees
Labels
Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

Steps

  1. Set the browser locale to french
  2. Switch the browser debugger to responsive view, select "iphone 6/7/8"
  3. Open the file list and wait

Expected result

File names all visible.
Toolbar with no overlap.

Actual result

File names appear shortly, then it seems some delayed function is recalculating the space and hides them, even though there is still some space left.
Toolbar buttons overlap, translation for home folder is longer than just "Home"

image

Version

git master

@PVince81 PVince81 added the Type:Bug Something isn't working label Feb 11, 2020
@PVince81 PVince81 changed the title Responsive files view with some locales look broken Responsive files view has file names truncated Feb 11, 2020
@PVince81
Copy link
Contributor Author

Hmm, also happens with English locale:
image

I believe this worked a few weeks ago.

@PVince81
Copy link
Contributor Author

It's a regression from v0.3.0.

Needs bisecting

@PVince81
Copy link
Contributor Author

breaking commit: 605e9ca

this collapsed the file actions by default, might need more changes.

somehow by looking at the behavior it almost looks like it's shrinking the file names twice (two steps visually) instead of just once

@PVince81
Copy link
Contributor Author

PR here: #2999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant