remove deleted files from search result #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
karakayasemi
force-pushed
the
fix-delete-from-search
branch
5 times, most recently
from
7f44dcf to
8a575d8
Compare
karakayasemi
force-pushed
the
fix-delete-from-search
branch
from
8a575d8 to
c8b7370
Compare
karakayasemi
force-pushed
the
fix-delete-from-search
branch
2 times, most recently
from
96c4566 to
1a8d212
Compare
|
Since more than once "lorem-big.txt" in skeleton files, the related test scenario was failing. I have refactored the related scenario by using different file name. |
individual-it
requested changes
Apr 24, 2020
karakayasemi
force-pushed
the
fix-delete-from-search
branch
from
1a8d212 to
bad10e7
Compare
LukasHirt
requested changes
Apr 24, 2020
karakayasemi
force-pushed
the
fix-delete-from-search
branch
from
bad10e7 to
5cddb2d
Compare
|
Changelog item has been added. @individual-it I guess, your change request is unintentional? |
LukasHirt
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deleted file removed from
filesSearchedstate by adding a new mutation. Also, filter condition in remove file mutations changed from object reference to unique file id.Related Issue
Motivation and Context
How Has This Been Tested?
Applied the described steps in the issues.
Types of changes\
Checklist: