Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocis] oc:privatelink webdav property not returned #262

Closed
dpakach opened this issue Oct 9, 2020 · 1 comment · Fixed by owncloud/ocis#4590
Closed

[ocis] oc:privatelink webdav property not returned #262

dpakach opened this issue Oct 9, 2020 · 1 comment · Fixed by owncloud/ocis#4590
Labels
enhancement New feature or request p3-medium

Comments

@dpakach
Copy link

dpakach commented Oct 9, 2020

On webdav responses oc:privatelink webdav properties are not returned

❯ curl -XPROPFIND https://localhost:9200/remote.php/webdav/Shares/hello.java --data-raw '<?xml version="1.0"?><d:propfind xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns" ><d:prop><oc:privatelink/></d:prop></d:propfind>' -u marie:radioactivity -sk | xmllint  --format -
<?xml version="1.0" encoding="utf-8"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/remote.php/webdav/Shares/hello.java</d:href>
    <d:propstat>
      <d:prop>
        <oc:privatelink/>
      </d:prop>
      <d:status>HTTP/1.1 404 Not Found</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>

in OC10

❯ curl -XPROPFIND http://localhost/fed/remote.php/webdav/block-aligned.txt -u admin:admin --data-raw '<?xml version="1.0"?><d:propfind xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns" ><d:prop><oc:privatelink/></d:prop></d:propfind>' -sk | xmllint  --format -

<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/fed/remote.php/webdav/block-aligned.txt</d:href>
    <d:propstat>
      <d:prop>
        <oc:privatelink>http://localhost/fed/f/51</oc:privatelink>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>

@dpakach dpakach added the bug Something isn't working label Oct 9, 2020
@butonic
Copy link
Member

butonic commented Mar 31, 2021

rendering of the property implemented in cs3org/reva#1604 ... but AFAICT oc10 renders different urls, depending on the ui that makes requests: old web ui or ocis web ...

@pmaier1 pmaier1 added enhancement New feature or request and removed bug Something isn't working labels Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p3-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants