Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right sidebar has initial focus when open upon page visit #10618

Closed
kulmann opened this issue Mar 15, 2024 · 0 comments · Fixed by #11609
Closed

Right sidebar has initial focus when open upon page visit #10618

kulmann opened this issue Mar 15, 2024 · 0 comments · Fixed by #11609
Assignees
Labels
Priority:p3-medium Normal priority Topic:Accessibility Type:Bug Something isn't working Web-only Issue without backend dependecies

Comments

@kulmann
Copy link
Contributor

kulmann commented Mar 15, 2024

Describe the bug

We now persist the open/closed state of the right sidebar in the localStorage of the browser and restore that state on the next visit (has been implemented in #10612 ).
In that case (open sidebar upon first page load) the right sidebar has the initial focus. That's an accessibility violation.

Steps to reproduce

  1. Open right sidebar anywhere
  2. Close the browser
  3. Reopen the browser

Expected behavior

There is no initial focus set. First TAB always jumps to the hidden button which let's the user navigate to the <main> content.

Actual behavior

Right sidebar is initially focussed. First TAB jumps to the X button to close the right sidebar.

@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority Topic:Accessibility labels Mar 15, 2024
@kulmann kulmann moved this from Qualification to Prio 3 or less in Infinite Scale Team Board Mar 15, 2024
@kulmann kulmann added the Web-only Issue without backend dependecies label Mar 15, 2024
@AlexAndBear AlexAndBear self-assigned this Mar 15, 2024
@AlexAndBear AlexAndBear removed their assignment Jun 4, 2024
@JammingBen JammingBen self-assigned this Sep 19, 2024
@JammingBen JammingBen moved this from Prio 3 or less to In progress in Infinite Scale Team Board Sep 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Topic:Accessibility Type:Bug Something isn't working Web-only Issue without backend dependecies
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants