Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed mode] Disable opening files via editors #10635

Closed
JammingBen opened this issue Mar 19, 2024 · 5 comments · Fixed by #10786
Closed

[Embed mode] Disable opening files via editors #10635

JammingBen opened this issue Mar 19, 2024 · 5 comments · Fixed by #10786
Assignees
@AlexAndBear
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working Web-only Issue without backend dependecies

Comments

@JammingBen
Copy link
Contributor

A question that came up yesterday: should the embed mode allow opening files via editors? IMO it misses the point of the embed mode a bit, since its purpose is basically to transfer files to/from a third party app, and not to work in files. Hence I'd suggest disabling it.

@kulmann @tbsbdr Opinions?
@kulmann
Copy link
Contributor

kulmann commented Mar 19, 2024

Same opinion.

1 similar comment
@tbsbdr
Copy link

tbsbdr commented Mar 20, 2024

Same opinion.

@kulmann
Copy link
Contributor

kulmann commented Mar 20, 2024

I'll label this as a p3 bug. IMO worth disabling in the stable-8.0 branch so that it gets included in the next ocis patch release.

@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Mar 20, 2024
@kulmann kulmann moved this from Qualification to Prio 3 or less in Infinite Scale Team Board Mar 20, 2024
@kulmann kulmann added the Web-only Issue without backend dependecies label Mar 20, 2024
@JammingBen JammingBen self-assigned this Mar 20, 2024
@JammingBen
Copy link
Contributor Author

I stumbled upon a question while implementing: what should actually happen, if you click e.g. a text file in embed mode? Should it trigger the download action like usually, if there is no editor found, or should it be un-clickable at all?

@JammingBen JammingBen removed their assignment Apr 11, 2024
@JammingBen JammingBen moved this from Prio 3 or less to Backlog in Infinite Scale Team Board Apr 11, 2024
@JammingBen
Copy link
Contributor Author

As discussed with @tbsbdr:

  • Clicking a filename in embed mode is the same as clicking the row itself (= file gets selected)

@AlexAndBear AlexAndBear self-assigned this Apr 15, 2024
@AlexAndBear AlexAndBear moved this from Backlog to In progress in Infinite Scale Team Board Apr 15, 2024
@AlexAndBear AlexAndBear mentioned this issue Apr 15, 2024
Merged
8 tasks
@AlexAndBear AlexAndBear moved this from In progress to Done in Infinite Scale Team Board Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexAndBear AlexAndBear

Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working Web-only Issue without backend dependecies
Projects
Infinite Scale Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable resource click and default editor action if embed mode is enabled owncloud/web
4 participants
@kulmann @AlexAndBear @tbsbdr @JammingBen