Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile size slider does not work for spaces #10638

Closed
JammingBen opened this issue Mar 20, 2024 · 2 comments · Fixed by #10646
Closed

Tile size slider does not work for spaces #10638

JammingBen opened this issue Mar 20, 2024 · 2 comments · Fixed by #10646
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working Web-only Issue without backend dependecies

Comments

@JammingBen
Copy link
Contributor

Describe the bug

The tile size slider does not affect the size of the tiles on the spaces overview.

Steps to reproduce

  1. Go to the "Spaces" overview and make sure you have at least 1 space
  2. Try changing the tile size via the tile size slider

Expected behavior

The size of the tiles change accordingly.

Actual behavior

The size stays the same.

Issue only exists on master, not on stable-8.0.

@JammingBen JammingBen added Type:Bug Something isn't working Priority:p3-medium Normal priority Web-only Issue without backend dependecies labels Mar 20, 2024
@JammingBen JammingBen moved this to Prio 3 or less in Infinite Scale Team Board Mar 20, 2024
@kulmann
Copy link
Contributor

kulmann commented Mar 20, 2024

Must be fallout from my #10558 then :-(

@pascalwengerter
Copy link
Contributor

Just had a look, seems like Projects.vue is missing the useResourcesViewDefaults composable?

diff --git a/packages/web-app-files/src/views/spaces/Projects.vue b/packages/web-app-files/src/views/spaces/Projects.vue
index b2d412fca..d4e6cee3f 100644
--- a/packages/web-app-files/src/views/spaces/Projects.vue
+++ b/packages/web-app-files/src/views/spaces/Projects.vue
@@ -54,6 +54,8 @@
             :sort-fields="sortFields"
             :sort-by="sortBy"
             :sort-dir="sortDir"
+            :header-position="fileListHeaderY /* table */"
+            :view-size="viewSize /* tiles */"
             v-bind="folderView.componentAttrs?.()"
             @sort="handleSort"
             @row-mounted="rowMounted"
@@ -180,6 +182,8 @@ import {
   ProcessorType,
   usePreviewService
 } from '@ownclouders/web-pkg'
+import { useResourcesViewDefaults } from '../../composables'
+
 import SpaceContextActions from '../../components/Spaces/SpaceContextActions.vue'
 import {
   isProjectSpaceResource,
@@ -264,6 +268,8 @@ export default defineComponent({
       'mdate'
     ]

+    const resourcesViewDefaults = useResourcesViewDefaults<Resource, any, any[]>()
+
     const sortFields = availableSortFields
     const {
       sortBy,
@@ -454,6 +460,7 @@ export default defineComponent({
     })

     return {
+      ...resourcesViewDefaults,
       ...useSideBar(),
       spaces,
       clientService,
(END)

@JammingBen JammingBen self-assigned this Mar 20, 2024
@JammingBen JammingBen moved this from Prio 3 or less to In progress in Infinite Scale Team Board Mar 20, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working Web-only Issue without backend dependecies
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants