Search is available but doesn't work for authenticated user on the public link page

[ScharfViktor]

Version | 5.1.0-prealpha+0ac03d8a8
web 9.0.0-alpha.5

Steps:

• create folders f1
• create link to the folder f1
• login in as marie and open link

Actual:

• Search is not available for public but what should we do if authenticated user? show or not search line?
• Search doesn't work - 401 Error

Expected: ? @kulmann maybe you have idea, what should we expect here?

[kulmann]

Nice finding! I'd expect that the search input is visible ( ✅ ) and that it works ( ❌ ) as this is an authenticated context. IMO the fact that the view being displayed belongs to a public link is not relevant for the rest of the screen layout (search, app menu, user menu, left sidebar nav).

[ScharfViktor]

I'd expect that the search input is visible ( ✅ ) and that it works ( ❌ ) as this is an authenticated context

yeah, search should work, thank you 👍
but the search result never gets to Marie the result which related to the public link

this can be confusing to the user. Maybe there's some way we can let the user know about it.

[AlexAndBear]

I am currently on master branch and admin shared a link. I login as Alex and open the public link from admin as soon I enter the password, I see the content and the search. I can hit the search and I will be able to find results.

Am I getting something wrong here, because it's not reproducible for me...

[ScharfViktor]

Am I getting something wrong here, because it's not reproducible for me...

I tied reproduce again. I can reproduce.

[AlexAndBear]

Can you check on web master with latest ocis ? it works for me

[ScharfViktor]

hmm, it works fine if I use https://ocis.ocis-wopi.latest.owncloud.works/
here https://github.com/owncloud/web/blob/master/docker-compose.yml it doesn't work

[ScharfViktor]

Can you check on web master with latest ocis ? it works for me

all fresh

[AlexAndBear]

We found the issue, this is happening because we are sending the basic auth header instead of the bearer token while doing the dav report request.

@ScharfViktor suggested disabling the search entirely when we are in a public link (context), because it will eventually be confusing to the user, that they can't search in the link but the personal space and other places

any opinion @kulmann @tbsbdr ?

[kulmann]

Good finding! No hard feelings. Fine by me to disable the search in that case 👍

[AlexAndBear]

I take over and remove it in this context as I think @ScharfViktor s
considering is valid