Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editors with save action (AppWrapper) don't use renewed token, 401 on save #11062

Closed
kulmann opened this issue Jun 19, 2024 · 2 comments · Fixed by #11068
Closed

Editors with save action (AppWrapper) don't use renewed token, 401 on save #11062

kulmann opened this issue Jun 19, 2024 · 2 comments · Fixed by #11068
Assignees
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Jun 19, 2024

Describe the bug

When I keep an editor open until after a token renewal has happened, attempting to save my work results in a 401. Apparently the renewed token is not being used, but the old expired one.

Steps to reproduce

  1. Create an .md file with out text editor app
  2. Write some content
  3. Wait until you see a token request in the network tab (= token renewal, happens every 5 minutes by default)
  4. Click Save in the app top bar

Expected behavior

Document gets saved.

Actual behavior

Document doesn't get saved. I see an error toast, but if I ignore that (and the warning about the dirty state when leaving the page) my work is lost.

Additional context

Needs fixing in current master and in stable-8.0.
@JammingBen and me already looked into this and think that the underlying issue is, that the webdav client gets destructured from the clientService and that the headers loose their reactivity with that.

@kulmann kulmann added Type:Bug Something isn't working Priority:p1-urgent Consider a hotfix release with only that fix labels Jun 19, 2024
@kulmann kulmann moved this from Qualification to Prio 1 in Infinite Scale Team Board Jun 19, 2024
@JammingBen JammingBen self-assigned this Jun 19, 2024
@JammingBen JammingBen moved this from Prio 1 to In progress in Infinite Scale Team Board Jun 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Jun 19, 2024
@jnweiger
Copy link
Contributor

Tested this with web-7.0.3 on oc10.15.0-rc.1 -- seems unaffected.

@AlexAndBear
Copy link
Contributor

Tested this with web-7.0.3 on oc10.15.0-rc.1 -- seems unaffected.

? oc10 + web 7 that's not really up 2 date, I don't think it makes sense to put effort into that outdated versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants