Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Show detailed information about a share #11101

Closed
AlexAndBear opened this issue Jun 25, 2024 · 7 comments · Fixed by #11166
Closed

FR: Show detailed information about a share #11101

AlexAndBear opened this issue Jun 25, 2024 · 7 comments · Fixed by #11166
Labels
Type:Story User Story

Comments

@AlexAndBear
Copy link
Contributor

As a user I want to know what I can do within a share (permissions). Especially if I am navigating in a secure view share

@kulmann
Copy link
Member

kulmann commented Jun 28, 2024

As far as I can see the backend doesn't expose this information, right? If that's correct, could you create an ocis issue for this? If it does I can take care of the web story.

@AlexAndBear
Copy link
Contributor Author

I think this information is in the GraphSharePermissions that are accessible trough sharing Ng ? Or am I wrong ?

@JammingBen
Copy link
Collaborator

The .../permissions endpoint for a resource returns all the graph permissions the user is allowed to share the resource with. You want to have that information for an existing share though, right?

I guess you can always query the permission that holds all necessary information. Or maybe the DAV permissions are sufficient? They should indicate what the user is allowed to do and what not.

@AlexAndBear
Copy link
Contributor Author

The .../permissions endpoint for a resource returns all the graph permissions the user is allowed to share the resource with. You want to have that information for an existing share though, right?

I guess you can always query the permission that holds all necessary information. Or maybe the DAV permissions are sufficient? They should indicate what the user is allowed to do and what not.

Yep about existing share. From what I remember of my implementation for secure view. The graph permissions are already persisted in the shared resource object

@JammingBen
Copy link
Collaborator

The graph permissions are already persisted in the shared resource object

Correct 👍 The terminology is a bit confusing here: a "share" in our terms is a "permission" in Graph terms. A "permission" in our terms is an "action" in Graph terms.

Still, the DAV permissions give away all necessary information, no? They are a bit more "digestable" than the Graph permissions.

@kulmann
Copy link
Member

kulmann commented Jul 3, 2024

They are a bit more "digestable" than the Graph permissions.

That's a sad thing to say about a new API 😢

@JammingBen
Copy link
Collaborator

Hmm not sure if I would agree. From a UI perspective - yes, definitely! But from a server perspective, having them so granular might actually be a good thing. IMO they are just not designed to be visualized in some UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants