Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent folder tooltip partially hidden behind other elements #11135

Closed
JammingBen opened this issue Jul 3, 2024 · 4 comments · Fixed by #11141
Closed

Parent folder tooltip partially hidden behind other elements #11135

JammingBen opened this issue Jul 3, 2024 · 4 comments · Fixed by #11141
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Collaborator

Describe the bug

The parent folder tooltip is partially hidden behind other elements.

Steps to reproduce

  1. Delete a file
  2. Navigate to the trash bin where the file is located
  3. Hover over the parent folder link

Expected behavior

The tooltip should be visible above other elements.

Actual behavior

The tooltip is partially hidden. Maybe a regression from #11087?

image
@pascalwengerter
Copy link
Contributor

Urgh, having caused that I'll take a look

@pascalwengerter pascalwengerter self-assigned this Jul 3, 2024
@pascalwengerter
Copy link
Contributor

I think I found the culprint, but the result doesn't really spark joy - do we really need to provide the hover with path prefix on the resource as well as the hover on the parent name underneath?

Screenshot 2024-07-04 at 12 33 50

@JammingBen
Copy link
Collaborator Author

I'd say the tooltip on the parent folder is sufficient... @tbsbdr or @kulmann might have different opinions though?

@github-project-automation github-project-automation bot moved this from Prio 3 or less to Done in Infinite Scale Team Board Jul 5, 2024
@kulmann
Copy link
Member

kulmann commented Jul 5, 2024

The tooltip on the file name is only really relevant if the file name gets truncated in the list. But afaik we can't know that and because of that we just always show the tooltip on the file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants